Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong font for bold text in WSL #10709

Closed
brneor opened this issue Jul 19, 2021 · 5 comments
Closed

Wrong font for bold text in WSL #10709

brneor opened this issue Jul 19, 2021 · 5 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@brneor
Copy link

brneor commented Jul 19, 2021

Windows Terminal version (or Windows build number)

1.10.1933.0

Other Software

WSL2

Steps to reproduce

Get any output that should be displayed in bold.

Expected Behavior

Bold text is displayed in same font which normal text is displayed.

image

Actual Behavior

Bold text is displayed in different font.

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 19, 2021
@zadjii-msft
Copy link
Member

Looks to me like that's the same font, just being displayed as bold, as requested. This was added in #109, #10498, and there's a setting to disable it in progress in #10648.

@zadjii-msft zadjii-msft added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Jul 19, 2021
@brneor
Copy link
Author

brneor commented Jul 19, 2021

Looks to me like that's the same font, just being displayed as bold, as requested. This was added in #109, #10498, and there's a setting to disable it in progress in #10648.

I have attached screenshots showing the difference from actual Fira Code Bold and the bold displayed when in WSL. I'm sorry if it was't clear enough:

Windows Terminal Preview Version 1.10.1933.0, Powershell:
image

Windows Terminal Preview Version 1.10.1933.0, WSL2 (Fedora, Ubuntu):
image

@zadjii-msft
Copy link
Member

Wait but the point I'm trying to make is that those two screenshots are showing the same font - just with different font weights. For example, here's the same output, but with Ubuntu Mono:

printf "\e[97mthis text is bright \e[mthis text isn't\n\e[1mthis text is bold   \e[mthis text isn't\n\n"

image

maybe with a better scheme:
image

The first line, the text is rendered like it was in 1.9 - without the bolding in response to 1m. The second line is the 1.10 variant. It's the same font for both, just, bold.

Which specific font are you using, and how are you emitting those lines of text?

@brneor
Copy link
Author

brneor commented Jul 19, 2021

I'm using the font "Fira Code" and the bold text in my screenshot was generated using tput. I tried running your snippet and result text for 'bold' is still the same:

image

I can assure you, although I can provide visual proof right now, that I'm getting correct bold variants for Fira Code in Gnome Terminal running natively on Fedora.

Edit: I'm so so sorry... Turns out I'm using the wrong font variant. Changing the font solved the issue. Thank you so much for your time and attention.

@Luvjeet
Copy link

Luvjeet commented Jul 30, 2023

what font variant did you used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

3 participants