Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taskbar Jumplist entries open in wt.exe instead of the application the jumplist belongs to (e.g., wtd.exe) #7554

Closed
Sidneys1 opened this issue Sep 7, 2020 · 10 comments · Fixed by #7567
Closed

Taskbar Jumplist entries open in wt.exe instead of the application the jumplist belongs to (e.g., wtd.exe) #7554

Sidneys1 opened this issue Sep 7, 2020 · 10 comments · Fixed by #7567
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Sidneys1
Copy link

Sidneys1 commented Sep 7, 2020 •
edited
Loading

Environment

Windows build number: 10.0.20206.0
Windows Terminal version (if applicable): dev build at master 9279b7a7

Steps to reproduce

  1. Right-click on "Windows Terminal Dev" from the start menu or taskbar
  2. Click a jumplist item

Expected behavior

The jumplist item opens the selected profile in "Windows Terminal Dev" (wtd.exe), since it was the application I right-clicked.

Actual behavior

The jumplist item attempts to open the selected profile in "Windows Terminal" from the Microsoft Store (wt.exe).

cG5lE2KJpC

Additionally, common profiles (like "Command Prompt" or "Windows PowerShell") open as expected in "Windows Terminal" wt.exe, but obviously profiles that are configured for "Windows Terminal Dev" (wtd.exe) don't exist in "Windows Terminal" (wt.exe) and open the default profile instead.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 7, 2020
@DHowett
Copy link
Member

DHowett commented Sep 7, 2020

You know, this is probably actually the result of running Windows Terminal outside of its package. Can you check the Version of the spawned instance? I bet it’s 0.0.0.1 or something equivalent to dev...

@Sidneys1
Copy link
Author

Sidneys1 commented Sep 7, 2020

Can you check the Version of the spawned instance?

0.0.1.0:

image

Should I be using a different workflow to build/install a Dev instance? Currently just "Build" and "Deploy" options on CascadiaPackage in Visual Studio.

@DHowett
Copy link
Member

DHowett commented Sep 7, 2020

No, no, this is just one of the unusual things we’ve learned about the app model. Since WT was layout-deployed (the way VS installs applications), the jumplist invocation is pointing at the actual binary on disk. Because WT supports unpackaged activation (activating by just double-clicking the EXE) file, it’s possible to run it “outside of the package”.

This is fixable, just surprising!

@DHowett
Copy link
Member

DHowett commented Sep 7, 2020

We’ll need to make the jump list entries optionally point at %LOCALAPPDATA%\Microsoft\WindowsApps\CurrentTerminalPFN\wt.exe instead of C:\Program Files\WindowsApps\PFN\WindowsTerminal.exe

@Sidneys1
Copy link
Author

Sidneys1 commented Sep 7, 2020

And here I was all excited about the jump-lists! Guess I'll have to wait a bit longer. :) Thanks for the quick responses!

@Sidneys1
Copy link
Author

Sidneys1 commented Sep 7, 2020

Once the fix comes I won't be able to use it until #7553 is fixed as well, that was my other report of the morning...

@DHowett
Copy link
Member

DHowett commented Sep 7, 2020

I mean, using the dev version as your daily driver is not recommended... but i’m definitely not here to stop you! 😁

@Sidneys1
Copy link
Author

Sidneys1 commented Sep 7, 2020

I also have Stable and Pre installed from the store, but I do like having my mitts on new bits, like the taskbar jumplists :)

DHowett added a commit that referenced this issue Sep 8, 2020
@DHowett
jumplist: prefer the app execution alias in %LOCALAPPDATA%
41bee14 
By setting the jumplist entries to launch `WindowsTerminal.exe` out of
the package root, we've inadvertently made WindowsTerminalDev emit jump
list entries that launch the _unpackaged_ version of Terminal.

We can fix this by copying the code from the shell extension that
determines which version of the executable to launch -- wt, wtd or
WindowsTerminal -- depending on the context under which it was invoked.

Fixes #7554.
@DHowett DHowett mentioned this issue Sep 8, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Sep 8, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 8, 2020
@ghost ghost closed this as completed in #7567 Sep 8, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 8, 2020
ghost pushed a commit that referenced this issue Sep 8, 2020
@DHowett
jumplist: prefer the app execution alias in %LOCALAPPDATA% (#7567)
b2cfd0a 
By setting the jumplist entries to launch `WindowsTerminal.exe` out of
the package root, we've inadvertently made WindowsTerminalDev emit jump
list entries that launch the _unpackaged_ version of Terminal.

We can fix this by copying the code from the shell extension that
determines which version of the executable to launch -- wt, wtd or
WindowsTerminal -- depending on the context under which it was invoked.

Fixes #7554
@DHowett
Copy link
Member

DHowett commented Sep 8, 2020

I also reverted the MUX update, so you should be good to go ;)

@Sidneys1
Copy link
Author

Sidneys1 commented Sep 8, 2020 via email

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jumplist: prefer the app execution alias in %LOCALAPPDATA% microsoft/terminal
2 participants
@DHowett @Sidneys1