jumplist: prefer the app execution alias in %LOCALAPPDATA% #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting the jumplist entries to launch `WindowsTerminal.exe` out of the package root, we've inadvertently made WindowsTerminalDev emit jump list entries that launch the _unpackaged_ version of Terminal. We can fix this by copying the code from the shell extension that determines which version of the executable to launch -- wt, wtd or WindowsTerminal -- depending on the context under which it was invoked. Fixes #7554.
|
@Sidneys1 may be happy to see this ;P |
carlos-zamora
approved these changes
Sep 8, 2020
leonMSFT
approved these changes
Sep 8, 2020
|
@msftbot merge this in 1 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the jumplist entries to launch
WindowsTerminal.exeout ofthe package root, we've inadvertently made WindowsTerminalDev emit jump
list entries that launch the unpackaged version of Terminal.
We can fix this by copying the code from the shell extension that
determines which version of the executable to launch -- wt, wtd or
WindowsTerminal -- depending on the context under which it was invoked.
Fixes #7554