Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal Dev Build crashes on start as of 5330759c #7553

Closed
Sidneys1 opened this issue Sep 7, 2020 · 1 comment
Closed

Windows Terminal Dev Build crashes on start as of 5330759c #7553

Sidneys1 opened this issue Sep 7, 2020 · 1 comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@Sidneys1
Copy link

Sidneys1 commented Sep 7, 2020

Environment

Windows build number: 10.0.20206.0
Windows Terminal version (if applicable): dev build (master branch)

Any other software?
Visual Studio 16.7.2

Steps to reproduce

  1. Check out any commit 5330759..7a03f75
  2. Build and deploy with Visual Studio 2019 (in Release x64 mode)
  3. Click on "Windows Terminal Dev" in Start Menu or Taskbar

Expected behavior

Windows Terminal starts as before

Actual behavior

A grey window without a titlebar appears briefly, then disappears:

aHEWPvM3FX

Other notes

An error at WindowsTerminal/main.cpp:132 occurs when running from Visual Studio:

image

The err.exe report for 0xC000027B does not seem immediately useful:

# for hex 0xc000027b / decimal -1073741189
  STATUS_STOWED_EXCEPTION                                        ntstatus.h
# An application-internal exception has occurred.
# as an HRESULT: Severity: FAILURE (1), FACILITY_NULL (0x0), Code 0x27b
# for hex 0x27b / decimal 635
  ERROR_COMMITMENT_MINIMUM                                       winerror.h
# {Virtual Memory Minimum Too Low}
# Your system is low on virtual memory. Windows is increasing
# the size of your virtual memory paging file.
# During this process, memory requests for some applications
# may be denied. For more information, see Help.
# 2 matches found for "0xC000027B"

git bisect nailed the bad commit down to 5330759:

git bisect start
# bad: [7a03f75ee9b905bd796d4d6a02f7cff3d5b1e472] Keep degenerate UIA text ranges degenerate after movement (#7530)
git bisect bad 7a03f75ee9b905bd796d4d6a02f7cff3d5b1e472
# good: [6acb9f8c90b1e4bc7837fd83fd60afddb46760bf] schema: swap `closeTabsAfter` and `closeOtherTabs` (#7386)
git bisect good 6acb9f8c90b1e4bc7837fd83fd60afddb46760bf
# good: [7803efa6fef8d2efd0d8fd93333cc958d8431882] Make GlobalAppSettings a WinRT object (#7349)
git bisect good 7803efa6fef8d2efd0d8fd93333cc958d8431882
# good: [97c2ccf08bbd2d2c24a33ccc415506a2fab6ffd2] Merge remote-tracking branch 'openconsole/inbox' into HEAD
git bisect good 97c2ccf08bbd2d2c24a33ccc415506a2fab6ffd2
# bad: [5330759c0f3d98b92209813c48e781a664fe22eb] Update to a newer MUX prerelease; remove workaround for compact sizing (#7447)
git bisect bad 5330759c0f3d98b92209813c48e781a664fe22eb
# good: [9279b7a73d3d6e0783ef38fa9cf2ad4406c14824] Add profiles to the Jumplist (#7515)
git bisect good 9279b7a73d3d6e0783ef38fa9cf2ad4406c14824
# first bad commit: [5330759c0f3d98b92209813c48e781a664fe22eb] Update to a newer MUX prerelease; remove workaround for compact sizing (#7447)
commit 5330759c0f3d98b92209813c48e781a664fe22eb
Author: Marcel Wagner <[email protected]>
Date:   Fri Sep 4 22:00:40 2020 +0200

    Update to a newer MUX prerelease; remove workaround for compact sizing (#7447)

    Update the WinUI version which allows us to remove the workaround.

    Closes #6681

 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj           |  4 ++--
 .../LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj      |  4 ++--
 .../LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj     |  2 +-
 src/cascadia/TerminalApp/TerminalAppLib.vcxproj                |  4 ++--
 src/cascadia/TerminalApp/TerminalPage.cpp                      | 10 ----------
 src/cascadia/TerminalApp/dll/TerminalApp.vcxproj               |  4 ++--
 src/cascadia/TerminalApp/packages.config                       |  2 +-
 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj           |  4 ++--
 src/cascadia/WindowsTerminal/packages.config                   |  2 +-
 .../WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj  |  4 ++--
 src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj              |  2 +-
 11 files changed, 16 insertions(+), 26 deletions(-)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 7, 2020
@krzysdz
Copy link
Contributor

krzysdz commented Sep 7, 2020

It appeared in commit 5330759 (PR #7447) because of a bug in MUX (microsoft/microsoft-ui-xaml#3104). There's already a PR for MUX, which should fix it (microsoft/microsoft-ui-xaml#3118), but it needs to be merged and included in a new (pre)release, before it can be updated in terminal.

@DHowett DHowett closed this as completed in 230b86c Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants