Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to a newer MUX prerelease; remove workaround for compact sizing #7447

Merged
3 commits merged into from
Sep 4, 2020
Merged

Update to a newer MUX prerelease; remove workaround for compact sizing #7447

3 commits merged into from
Sep 4, 2020

Conversation

marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Aug 28, 2020 •
edited by DHowett
Loading

Update the WinUI version which allows us to remove the workaround.

Closes #6681

@ghost ghost added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 28, 2020
@DHowett DHowett changed the title Remove workaround used for TabView compact sizing bug, bump WinUI version Update to a newer MUX prerelease; remove workaround for compact sizing Sep 4, 2020
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 4, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5330759 into microsoft:master Sep 4, 2020
@DHowett
Copy link
Member

DHowett commented Sep 4, 2020

Thanks for this 😄

@marcelwgn
Copy link
Contributor Author

Always happy to help! 😃

DHowett added a commit that referenced this pull request Sep 5, 2020
@DHowett
Revert "Update to a newer MUX prerelease; remove workaround for compa…
cb25694 
…ct sizing (#7447)"

This reverts commit 5330759.
@mrange mrange mentioned this pull request Sep 6, 2020
Closed
6 tasks
@Sidneys1 Sidneys1 mentioned this pull request Sep 7, 2020
Closed
DHowett added a commit that referenced this pull request Sep 8, 2020
@DHowett
Revert "Update to a newer MUX prerelease; remove workaround for compa…
230b86c 
…ct sizing (#7447)"

This reverts commit 5330759.

Fixes #7553
@DHowett
Copy link
Member

DHowett commented Sep 8, 2020

Pushed a revert for this; when there's a newer prerelease available I'll un-revert this revert (because it'll re-remove the Compact workaround)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove workaround "When we add a new tab in compact mode, re-enforce Compact mode"
4 participants
@marcelwgn @DHowett @carlos-zamora @zadjii-msft