Regression in launching links

[chrisant996]

Windows Terminal version

1.21.1272.0

Windows build number

19045.4412

Other Software

No response

Steps to reproduce

1. Open a cmd.exe tab in Terminal.
2. Run echo Hello ^(https://github.com/chrisant996/clink^).
3. Move the mouse over the hyperlink -- observe that the hyperlink is underlined correctly.
4. Ctrl+Click the hyperlink -- the ) is mistakenly included in the URL, and causes the web navigation to fail.

Expected Behavior

It should open the link https://github.com/chrisant996/clink.
It should open the same link that it underlined.
Terminal 1.19.11213.0 works correctly.

Actual Behavior

It opened the link https://github.com/chrisant996/clink) -- note that the ) was mistakenly included.
What it opens is different from what it underlined.

[tusharsnx]

Thanks for reporting this.

I believe result->stop is an exclusive coord, but it was passed down to the .GetPlainText() which expects inclusive coords:

terminal/src/cascadia/TerminalCore/Terminal.cpp

Line 525 in 5d1cf1a

return _activeBuffer().GetPlainText(result->start, result->stop);

On it.

[DHowett]

@tusharsnx, @lhecker do either of you know if this will impact 1.20 as well?

[DHowett]

Checked it out - yes, 1.20 is impacted. I'll service this.

Thanks @chrisant996 for the report!

[chrisant996]

Ah, I see, yes it's fresh, introduced by 5b8eadb a month ago. 👍

[Psypher1]

Hello, I was told my issue #17424 is already being tracked here. My question; I see a merge was done. Does that mean I should update terminal to enact the changes? However the most recent release is still preview...

Because while the merge sort of handle a similar issue, it's not quite what I'm experiencing

[lhecker]

Preview will receive the fix sometime soon. Until then you can test out our nightly version here: https://aka.ms/terminal-canary-installer
Don't worry: If you uninstall it later, no traces will be left behind. :)