Fix hyperlinks using an extra character at the end #17326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
May 28, 2024
Comment on lines
+525
to
+527
| // GetPlainText works with inclusive coordinates, but interval's stop | ||
| // point is (horizontally) exclusive, so let's just update it. | ||
| result->stop.x--; |
There was a problem hiding this comment.
Note to other reviewers: This works because of line 1425 in Terminal::_getPatterns.
DHowett
pushed a commit
that referenced
this pull request
Jun 7, 2024
Closes: #17323 - Run `echo Hello ^(https://github.com/microsoft/terminal^)` in cmd. - Ctrl+click on the URL opens `https://github.com/microsoft/terminal` in the browser. - Hovering over the url in the terminal shows `https://github.com/microsoft/terminal` in the hover UI. (cherry picked from commit 212f43e) Service-Card-Id: 92637504 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
Jun 7, 2024
Closes: #17323 ## Validation Steps Performed - Run `echo Hello ^(https://github.com/microsoft/terminal^)` in cmd. - Ctrl+click on the URL opens `https://github.com/microsoft/terminal` in the browser. - Hovering over the url in the terminal shows `https://github.com/microsoft/terminal` in the hover UI. (cherry picked from commit 212f43e) Service-Card-Id: 92637505 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #17323
Validation Steps Performed
echo Hello ^(https://github.com/microsoft/terminal^)in cmd.https://github.com/microsoft/terminalin the browser.https://github.com/microsoft/terminalin the hover UI.