Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicked URL contains unwanted delimiter #17430

Closed
bobvandevijver opened this issue Jun 13, 2024 · 3 comments
Closed

Clicked URL contains unwanted delimiter #17430

bobvandevijver opened this issue Jun 13, 2024 · 3 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@bobvandevijver
Copy link

Windows Terminal version

1.20.11381.0

Windows build number

10.0.22631.0

Other Software

My screenshot is a irssi inside a screen over SSH inside WSL Debian, but it happens in any environment.

Steps to reproduce

Have a link wrapped with <> in your terminal, for example in bash:

echo "Some URL: <https://github.com>"

And click the link in the output.

Expected Behavior

The parsed link should not include the > character. Angle brackets are a common URL/IRI delimiter, which is not allowed in IRIs.

Actual Behavior

The opened link will include the > character, which can lead to interesting behaviour. The example above with Github leads me to an empty tab, the example from the screenshot below leads to a 404 (which isn't the case when the > is removed).

Also note that the > isn't actually underlined (which is good), but it is included in the mouseover and when clicked.

image

@bobvandevijver bobvandevijver added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 13, 2024
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #17323 for more discussion.

/dup #17323

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2024
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 13, 2024
@bobvandevijver
Copy link
Author

A, didn't see that one as it was already closed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants