Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate RN Nightly 10/20 #14092

Merged
merged 41 commits into from
Nov 22, 2024
Merged

Conversation

Yajur-Grover
Copy link
Contributor

@Yajur-Grover Yajur-Grover commented Nov 7, 2024

Description

Integration
Commit Range: facebook/react-native@0d6908f...e7a3f47

Notable Commits

Changelog

Should this change be included in the release notes: no

Additional Notes:

  • I did various fixes to MS.RN.Cxx to properly build up its header structure within the repo, rather than just on nuget publish. This allows removal of a bunch of the bridging patches, and unifies the include path configs better inside the repo and with real apps.
  • I patched bridging/base.h to deal with some MSVC issues: (Upstream changes to bridging\Base.h to build correctly on MSVC #14130 tracks removal)
  • This allows us to add the DefaultTurboModules from core into our TurboModuleManager. These use the bridging APIs so they needed to be fixed.
  • I then stubbed out MicroTaskTurboModule for now, since it uses some queueMicrotask which the current version of nodejsi we are using does not support.
  • In order to avoid requiring the MicroTaskTurboModule I added an implementation of ReactNativeFeatureFlags to allow us to override the default value of disableEventLoopOnBridgeless, which will disable usage of the MicoTaskTurboModule.
  • I created a patch of TurboModule.h to avoid an issue with the caching JS object used there. - [NodeAPI] TurboModule jsRespresentation_ cache fails to set property #14128 tracks reanabling this cache and removing the patch
Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms marked this pull request as ready for review November 22, 2024 04:07
@acoates-ms acoates-ms requested review from a team as code owners November 22, 2024 04:07
@Yajur-Grover Yajur-Grover merged commit 8be3904 into microsoft:main Nov 22, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants