Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN: Fix lint/sort-imports Errors #47109

Closed
wants to merge 1 commit into from

Conversation

yungsters
Copy link
Contributor

Summary:
Fixes the lint/sort-imports errors that are now surfaced after fixing the lint configuration.

For a couple files, I added lint suppressions instead because the unsorted import ordering is important due to interleaved calls with side effects.

Changelog:
[Internal]

Differential Revision: D64569485

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64569485

Summary:
Pull Request resolved: facebook#47109

Fixes the `lint/sort-imports` errors that are now surfaced after fixing the lint configuration.

For a couple files, I added lint suppressions instead because the unsorted import ordering is important due to interleaved calls with side effects.

Changelog:
[Internal]

Differential Revision: D64569485
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64569485

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c9ea055.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 18, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @yungsters in c9ea055

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants