Fix dark mode text #46898
Closed
Fix dark mode text #46898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64053464 |
|
This pull request was exported from Phabricator. Differential Revision: D64053464 |
Abbondanzo
force-pushed
the
export-D64053464
branch
from
f007734
to
81c2472
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Pull Request resolved: facebook#46898 Replaces *many* `Text` component usages with `RNTesterText`: a thin wrapper around `Text` that applies color based on the color scheme chosen by the user. It makes text legible for dark mode across 41 different example files. This changes intentionally do not touch a few larger component sites that expand beyond RNTester, like `Animated` and `NewAppScreen` Changelog: [Internal] Differential Revision: D64053464
Summary: Pull Request resolved: facebook#46898 Replaces *many* `Text` component usages with `RNTesterText`: a thin wrapper around `Text` that applies color based on the color scheme chosen by the user. It makes text legible for dark mode across 41 different example files. This changes intentionally do not touch a few larger component sites that expand beyond RNTester, like `Animated` and `NewAppScreen` Changelog: [Internal] Differential Revision: D64053464
|
This pull request was exported from Phabricator. Differential Revision: D64053464 |
Abbondanzo
force-pushed
the
export-D64053464
branch
from
81c2472
to
a81789d
Compare
|
This pull request has been merged in 09682b5. |
|
This pull request was successfully merged by @Abbondanzo in 09682b5 When will my fix make it into a release? | How to file a pick request? |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces many
Textcomponent usages withRNTesterText: a thin wrapper aroundTextthat applies color based on the color scheme chosen by the user. It makes text legible for dark mode across 41 different example files. This changes intentionally do not touch a few larger component sites that expand beyond RNTester, likeAnimatedandNewAppScreenChangelog: Internal
Differential Revision: D64053464