Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.66] Add inline comments to suppress a security analysis (bandit) rule for Folly #1291

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[0.66] Add inline comments to suppress a security analysis (bandit) rule for Folly #1291

merged 1 commit into from
Jul 25, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Cherry pick 721b812 into 0.66-stable

@Saadnajmi Saadnajmi requested review from a team as code owners July 25, 2022 19:24
@Saadnajmi Saadnajmi changed the base branch from main to 0.66-stable July 25, 2022 19:24
@Saadnajmi Saadnajmi changed the title [0.66] Add inline comments to suppress a security analysis (bandit) rule [0.66] Add inline comments to suppress a security analysis (bandit) rule for Folly Jul 25, 2022
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 416ea50

@Saadnajmi Saadnajmi merged commit d3de93c into microsoft:0.66-stable Jul 25, 2022
@Saadnajmi Saadnajmi deleted the suppress-comment branch July 25, 2022 21:14
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
Use reference Yoga CMake build (microsoft#1291)
2364c14 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: fe6f67a9be7e4bb1ada0e9998f5fe2c015472fa4
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
Use reference Yoga CMake build (microsoft#1291)
41fb92a 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: c6204727d509793962301621079c4f13608828f9
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
DRAFT: Use reference Yoga CMake build (microsoft#1291)
345e464 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: de48d6419424c23a31f04ae18423883d0baaf7a8
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
DRAFT: Use reference Yoga CMake build (microsoft#1291)
6f80a35 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 6580a7f07120ceebf3c0623e86c1865461af72cc
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
DRAFT: Use reference Yoga CMake build (microsoft#1291)
29dd827 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 4e661cf829babd3de1827cdc0dc277156fa4b9db
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
DRAFT: Use reference Yoga CMake build for libyogacore (microsoft#1291)
dc32593 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: fd4b3165ddffb32375b2840d9ae8635689104bde
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
DRAFT: Use reference Yoga CMake build for libyogacore (microsoft#1291)
4bf7b9a 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: e756f1f101579fabbb55b0111e0e3ab38151b4d5
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
DRAFT: Use reference Yoga CMake build for libyogacore (microsoft#1291)
4197691 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 6a2454c0c211745137ee8eada78704b24e6f93a3
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
Use reference Yoga CMake build for libyogacore (microsoft#1291)
a828ef3 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 7c20dd01fefaa759b5cea92c06fbacdc110fe5a1
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
Use reference Yoga CMake build for libyogacore (microsoft#1291)
bd16f78 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 36bae3a25faafecb76a3de74cdf8e952dbf59726
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
@NickGerleman @facebook-github-bot
Use reference Yoga CMake build for libyogacore (microsoft#1291)
4e2e217 
Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Reviewed By: cortinico

Differential Revision: D45764537

fbshipit-source-id: a98c85033c219df7e55365aa8358a516a0c45fc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiuam chiuam chiuam approved these changes

@mischreiber mischreiber mischreiber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Saadnajmi @pull-bot @mischreiber @chiuam @dannyvv