Use reference Yoga CMake build (#37371) #1291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
Summary: Pull Request resolved: facebook#1291 X-link: facebook/react-native#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: f3fcbe98eea6a4f87cb6305448e35dd5856852d7
NickGerleman
force-pushed
the
export-D45764537
branch
from
25e49e3 to
ea5fc0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45764537 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: fe6f67a9be7e4bb1ada0e9998f5fe2c015472fa4
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: c6204727d509793962301621079c4f13608828f9
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: de48d6419424c23a31f04ae18423883d0baaf7a8
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: 6580a7f07120ceebf3c0623e86c1865461af72cc
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: 4e661cf829babd3de1827cdc0dc277156fa4b9db
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings.˜˜ Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: fd4b3165ddffb32375b2840d9ae8635689104bde
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings.˜˜ Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: e756f1f101579fabbb55b0111e0e3ab38151b4d5
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings.˜˜ Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: 6a2454c0c211745137ee8eada78704b24e6f93a3
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 **Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub. This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings.˜˜ Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: 7c20dd01fefaa759b5cea92c06fbacdc110fe5a1
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings. Changelog: [Android][Changed] - Use reference Yoga CMake Build Differential Revision: D45764537 fbshipit-source-id: 36bae3a25faafecb76a3de74cdf8e952dbf59726
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: facebook#37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings. Changelog: [Android][Changed] - Use reference Yoga CMake Build Reviewed By: cortinico Differential Revision: D45764537 fbshipit-source-id: a98c85033c219df7e55365aa8358a516a0c45fc0
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1291 Pull Request resolved: #37371 This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win). This does not yet do the same for the Yoga JNI bindings. Changelog: [Android][Changed] - Use reference Yoga CMake Build Reviewed By: cortinico Differential Revision: D45764537 fbshipit-source-id: 1aafd221d2afa994b6efae3c267ee7ffbdf0faad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#37371
This makes React Native use
libyogacoreas provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).Changelog:
[Android][Changed] - Use reference Yoga CMake Build
Differential Revision: D45764537