New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reference Yoga CMake build for libyogacore #37371

Closed

NickGerleman wants to merge 1 commit into facebook:main from NickGerleman:export-D45764537

Contributor

NickGerleman commented May 11, 2023

Summary: This makes React Native use libyogacore as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally.

Differential Revision: D45764537

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

analysis-bot commented May 11, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,724,104	-2,677
android	hermes	armeabi-v7a	8,035,097	-2,504
android	hermes	x86	9,212,686	-1,216
android	hermes	x86_64	9,065,899	-2,222
android	jsc	arm64-v8a	9,288,840	-2,678
android	jsc	armeabi-v7a	8,477,266	-2,500
android	jsc	x86	9,348,814	-1,214
android	jsc	x86_64	9,605,624	-2,236

Base commit: f5759d7
Branch: main

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Use reference Yoga CMake build (facebook#37371)

c3ee77b

Summary:
Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally.

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 2da30de434838a155078571496ccdd30eccd75fc

NickGerleman force-pushed the export-D45764537 branch from b931573 to c3ee77b Compare

May 11, 2023 05:37

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request


          Use reference Yoga CMake build (#37371)

25e49e3

Summary:
X-link: facebook/react-native#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 0c250d6aaa8298205fc94fd980953f51659197de

NickGerleman mentioned this pull request

Use reference Yoga CMake build (#37371) facebook/yoga#1291

Closed

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request


          Use reference Yoga CMake build (facebook#1291)

ea5fc0f

Summary:
Pull Request resolved: facebook#1291

X-link: facebook/react-native#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: f3fcbe98eea6a4f87cb6305448e35dd5856852d7

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Use reference Yoga CMake build (microsoft#1291)

2364c14

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: fe6f67a9be7e4bb1ada0e9998f5fe2c015472fa4

NickGerleman force-pushed the export-D45764537 branch from c3ee77b to 2364c14 Compare

May 11, 2023 06:00

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Use reference Yoga CMake build (microsoft#1291)

41fb92a

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: c6204727d509793962301621079c4f13608828f9

NickGerleman force-pushed the export-D45764537 branch from 2364c14 to 41fb92a Compare

May 11, 2023 06:06

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          DRAFT: Use reference Yoga CMake build (microsoft#1291)

345e464

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: de48d6419424c23a31f04ae18423883d0baaf7a8

NickGerleman force-pushed the export-D45764537 branch from 41fb92a to 345e464 Compare

May 11, 2023 06:17

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          DRAFT: Use reference Yoga CMake build (microsoft#1291)

6f80a35

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 6580a7f07120ceebf3c0623e86c1865461af72cc

NickGerleman force-pushed the export-D45764537 branch from 345e464 to 6f80a35 Compare

May 11, 2023 07:20

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          DRAFT: Use reference Yoga CMake build (microsoft#1291)

29dd827

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 4e661cf829babd3de1827cdc0dc277156fa4b9db

NickGerleman force-pushed the export-D45764537 branch from 6f80a35 to 29dd827 Compare

May 11, 2023 07:26

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman force-pushed the export-D45764537 branch from 29dd827 to dc32593 Compare

May 11, 2023 07:41

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          DRAFT: Use reference Yoga CMake build for libyogacore (microsoft#1291)

dc32593

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: fd4b3165ddffb32375b2840d9ae8635689104bde

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          DRAFT: Use reference Yoga CMake build for libyogacore (microsoft#1291)

4bf7b9a

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: e756f1f101579fabbb55b0111e0e3ab38151b4d5

NickGerleman force-pushed the export-D45764537 branch from dc32593 to 4bf7b9a Compare

May 11, 2023 07:53

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman changed the title ~~Use reference Yoga build~~ Use reference Yoga CMake build for libyogacore

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          DRAFT: Use reference Yoga CMake build for libyogacore (microsoft#1291)

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 6a2454c0c211745137ee8eada78704b24e6f93a3

NickGerleman force-pushed the export-D45764537 branch from 4bf7b9a to 4197691 Compare

May 11, 2023 08:26

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Use reference Yoga CMake build for libyogacore (microsoft#1291)

a828ef3

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

**Draft:** This is a draft change that I cannot make a draft in Phabricator because I want to export it to GitHub.

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.˜˜

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 7c20dd01fefaa759b5cea92c06fbacdc110fe5a1

NickGerleman force-pushed the export-D45764537 branch from 4197691 to a828ef3 Compare

May 11, 2023 09:09

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Use reference Yoga CMake build for libyogacore (microsoft#1291)

bd16f78

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Differential Revision: D45764537

fbshipit-source-id: 36bae3a25faafecb76a3de74cdf8e952dbf59726

NickGerleman force-pushed the export-D45764537 branch from a828ef3 to bd16f78 Compare

May 11, 2023 09:46

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537


          Use reference Yoga CMake build for libyogacore (microsoft#1291)

4e2e217

Summary:
X-link: facebook/yoga#1291

Pull Request resolved: facebook#37371

This makes React Native use `libyogacore` as provided by Yoga's reference CMake build. This in turn matches Yoga in the OSS RN build to the same compilation settings we use internally. It also means less differences between all the builds (maintainability win).

This does not yet do the same for the Yoga JNI bindings.

Changelog:
[Android][Changed] - Use reference Yoga CMake Build

Reviewed By: cortinico

Differential Revision: D45764537

fbshipit-source-id: a98c85033c219df7e55365aa8358a516a0c45fc0

NickGerleman force-pushed the export-D45764537 branch from bd16f78 to 4e2e217 Compare

May 11, 2023 14:25

Contributor

facebook-github-bot commented May 11, 2023

This pull request was exported from Phabricator. Differential Revision: D45764537

facebook-github-bot closed this in

6764ada

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented May 11, 2023

This pull request has been merged in 6764ada.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner