-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public deployment #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
added a commit
that referenced
this pull request
Aug 9, 2016
* Adding autoscroll utility and marquee selection. * More fixes. * Enables selection preservation even when items dematerialize. * Math rounding tweak in auto scrolling. * Updating small nits. * Adding example page, improving props documentation, adding memoization to measures to improve performance. * More performance improvements. * Moving files to a more logical location. * Missing an index change. * Adding more best practices content. * Updating documentation. * Removing unnecessary call. * Removing dir from html. * Removing an unnecessary measure from autoscroll. * Updating basic details list example to use marquee selection. * With scrolltop fix (#3) * With scrolltop fix. * addressing lint issues * Improving the example by removing the images. * Removing the scroll monitoring and css tweaking from Fabric component, due to performance. * Fixing issues related to safari support. * Minor improvement to EventGroup. * Lint fixes. * Updates for PR comments. * Fixing hovers. * A few more fixes to test page and styles. * Removing lint error. * Cleanup. * Adds ability to select from anywhere in the scrollable parent. Also fixes column draggging to use native eventing to play well with marquee selection.
dzearing
added a commit
that referenced
this pull request
Aug 11, 2016
* Adding autoscroll utility and marquee selection. * More fixes. * Enables selection preservation even when items dematerialize. * Math rounding tweak in auto scrolling. * Updating small nits. * Adding example page, improving props documentation, adding memoization to measures to improve performance. * More performance improvements. * Moving files to a more logical location. * Missing an index change. * Adding more best practices content. * Updating documentation. * Removing unnecessary call. * Removing dir from html. * Removing an unnecessary measure from autoscroll. * Updating basic details list example to use marquee selection. * With scrolltop fix (#3) * With scrolltop fix. * addressing lint issues * Improving the example by removing the images. * Removing the scroll monitoring and css tweaking from Fabric component, due to performance. * Fixing issues related to safari support. * Minor improvement to EventGroup. * Lint fixes. * Updates for PR comments. * Fixing hovers. * Updating checkbox to a cleaner contract. This is a breaking change for CheckBox! * Updating comments. * Minor pr updates. * Feedback. * Updating focuszone to have inputProps. * Tweaks to documentation. * Adding a class interface.
gokunymbus
referenced
this pull request
in gokunymbus/office-ui-fabric-react
Jan 24, 2017
Public deployment
gokunymbus
referenced
this pull request
in gokunymbus/office-ui-fabric-react
Jan 24, 2017
* Adding autoscroll utility and marquee selection. * More fixes. * Enables selection preservation even when items dematerialize. * Math rounding tweak in auto scrolling. * Updating small nits. * Adding example page, improving props documentation, adding memoization to measures to improve performance. * More performance improvements. * Moving files to a more logical location. * Missing an index change. * Adding more best practices content. * Updating documentation. * Removing unnecessary call. * Removing dir from html. * Removing an unnecessary measure from autoscroll. * Updating basic details list example to use marquee selection. * With scrolltop fix (#3) * With scrolltop fix. * addressing lint issues * Improving the example by removing the images. * Removing the scroll monitoring and css tweaking from Fabric component, due to performance. * Fixing issues related to safari support. * Minor improvement to EventGroup. * Lint fixes. * Updates for PR comments. * Fixing hovers. * A few more fixes to test page and styles. * Removing lint error. * Cleanup. * Adds ability to select from anywhere in the scrollable parent. Also fixes column draggging to use native eventing to play well with marquee selection.
gokunymbus
referenced
this pull request
in gokunymbus/office-ui-fabric-react
Jan 24, 2017
* Adding autoscroll utility and marquee selection. * More fixes. * Enables selection preservation even when items dematerialize. * Math rounding tweak in auto scrolling. * Updating small nits. * Adding example page, improving props documentation, adding memoization to measures to improve performance. * More performance improvements. * Moving files to a more logical location. * Missing an index change. * Adding more best practices content. * Updating documentation. * Removing unnecessary call. * Removing dir from html. * Removing an unnecessary measure from autoscroll. * Updating basic details list example to use marquee selection. * With scrolltop fix (#3) * With scrolltop fix. * addressing lint issues * Improving the example by removing the images. * Removing the scroll monitoring and css tweaking from Fabric component, due to performance. * Fixing issues related to safari support. * Minor improvement to EventGroup. * Lint fixes. * Updates for PR comments. * Fixing hovers. * Updating checkbox to a cleaner contract. This is a breaking change for CheckBox! * Updating comments. * Minor pr updates. * Feedback. * Updating focuszone to have inputProps. * Tweaks to documentation. * Adding a class interface.
This was referenced Apr 28, 2017
2 tasks
2 tasks
2 tasks
sopranopillow
added a commit
to sopranopillow/fluentui
that referenced
this pull request
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public Deployment
We have now created an external deployment task for deploying your branch via FTP. There are no credentials in this deployment and to use this it will require your own web/FTP service.
Getting started
In order to get the deployment working you have to run
gulp install-deploy
. Gulp with then prompt you with the information needed to get the deployment up and running. Once you provide this information that task will create a file in the root of your project calledftpconfig.json
. You will need to provide:ftp.example.com
ftpuserexample
ftpSuperSecretPassword1
http://example.com/website-subfolder/
/wwwroot/base/path/website-subfolder/
true
1000
After the install is complete run
gulp deploy
. This task will build the entire project and deploy your project to your ftp server and provide a URL corresponding to the location of the files on your server.Issues
If you run into any issues you can open up
ftpconfig.json
in the root and double check all the credentials and information. You can make direct edits to the file and save, and re-rungulp deploy
. You can also re-rungulp install-deploy
and enter in all the prompted values.More information about each property
Hostname
Hostname is generally your domain name like
example.com
orftp.example.com
FTP Username
This is just the FTP username provided by your web hosting service.
FTP Password
Your FTP password!
Deployment base URL
This will be the base URL for accessing your deployed files. Gulp will take this URL, combine it with your machine and branch name and print out a complete unique URL to the location of your React project on your web server.
http://example.com/website-folder/ExampleMachineName-ExampleBranchName
. thefabric-react-development
is a path on your server that you choose.Deployment Base Path
The deployment base path is the physical file path on your server where you want Fabric React to create new folders to upload your branch and project files to.
Secure connection
If you need the connection to be secure choose yes.
Idle timeout
Time in milliseconds to keep the connection open while no uploads are happening.