FocusZone now takes in rootProps #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging latest
…-react into marquee-selection # Conflicts: # src/components/DetailsList/DetailsList.tsx
…n to measures to improve performance.
* With scrolltop fix. * addressing lint issues
…, due to performance.
…c-react into checkbox-updates # Conflicts: # src/components/DetailsList/DetailsHeader.tsx # src/components/MarqueeSelection/MarqueeSelection.Props.ts # src/components/MarqueeSelection/MarqueeSelection.tsx # src/demo/pages/DetailsListPage/examples/DetailsList.Basic.Example.tsx # src/demo/pages/MarqueeSelectionPage/examples/MarqueeSelection.Basic.Example.tsx
…c-react into focuszone-updates # Conflicts: # src/components/Checkbox/Checkbox.Props.ts
…c-react into focuszone-updates # Conflicts: # src/components/CommandBar/CommandBar.tsx # src/components/ContextualMenu/ContextualMenu.tsx # src/components/FocusZone/FocusZone.Props.ts # src/components/FocusZone/FocusZone.tsx
|
Approved |
gokunymbus
pushed a commit
to gokunymbus/office-ui-fabric-react
that referenced
this pull request
Jan 24, 2017
* Adding autoscroll utility and marquee selection. * More fixes. * Enables selection preservation even when items dematerialize. * Math rounding tweak in auto scrolling. * Updating small nits. * Adding example page, improving props documentation, adding memoization to measures to improve performance. * More performance improvements. * Moving files to a more logical location. * Missing an index change. * Adding more best practices content. * Updating documentation. * Removing unnecessary call. * Removing dir from html. * Removing an unnecessary measure from autoscroll. * Updating basic details list example to use marquee selection. * With scrolltop fix (#3) * With scrolltop fix. * addressing lint issues * Improving the example by removing the images. * Removing the scroll monitoring and css tweaking from Fabric component, due to performance. * Fixing issues related to safari support. * Minor improvement to EventGroup. * Lint fixes. * Updates for PR comments. * Fixing hovers. * Updating checkbox to a cleaner contract. This is a breaking change for CheckBox! * Updating comments. * Minor pr updates. * Feedback. * Updating focuszone to have inputProps. * Tweaks to documentation. * Adding a class interface.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FocusZone to take in rootProps and remove the warnings thrown by React.