Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider A11y Pass #7115

Closed
5 tasks done
TestAccessibilityGIT opened this issue Nov 15, 2018 · 16 comments
Closed
5 tasks done

Slider A11y Pass #7115

TestAccessibilityGIT opened this issue Nov 15, 2018 · 16 comments

Comments

@TestAccessibilityGIT
Copy link

TestAccessibilityGIT commented Nov 15, 2018

Tracking all of the issues brought up with the 11/13 accessibility pass on Slider control
Details on individual bugs can be found on SharePoint

  • Bug 1: [Accessibility][Screen reader]: In Scan mode user is not able to change the slider value. This is an external issue (Edge team is tracking it internally.)
  • Bug 2: [Accessibility][Usable]: Narrator does not narrate the complete information while changing the slider values. (Duplicated by [Accessibility] Slider: Doesn't Announce Current Value #7993)
  • Bug 3: [Accessibility][Screen Reader]: In scan mode narrator does not narrate the slider value. Bugs 3, 4, 5: same behavior on reference example - looks like a byproduct of Bug 1 which is inability to change the slider in scan mode. Seems like the problem's with Edge.
  • Bug 4: [Accessibility][Usable]: Scan mode focus is not visible on slider in backward navigation.
  • Bug 5: [Accessibility][Usable]: Screen does not scroll down along with keyboard focus in back navigation.
    @micahgodbolt
@aneeshack4
Copy link
Contributor

aneeshack4 commented Dec 20, 2018

@TestAccessibilityGIT These are all non-repro, please see video below. Perhaps you didn't use Alt + back/forward arrow keys to change slider values properly and use shift + tab for backward navigation - that might be why these didn't work for you (that's Bugs 1 and 5). Bug 2 and 3: You can see in the Narrator Buddy output in the video that it is reading out the values even as the Slider's being changed, and while in Scan mode. Bug 4: you can see the focus rects during backward navigation are accurate. I'm unable to upload this video to Github (I used Microsoft Expression Encoder like you suggested in our previous conversation about the Checkbox A11y pass) so I've uploaded it to Onedrive & made it accessible to anyone with this link.

@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

@JasonGore
Copy link
Member

Just a general note here: We should be reporting the browser and browser version used when both reporting and responding to issues as no repro.

@JasonGore
Copy link
Member

JasonGore commented Feb 14, 2019

@aneeshack4 Microsoft Edge has an active and open issue against Bug 1. Bug 2 also appears to be reported in #7993 and I've reproed it. Can you confirm that you tested with Microsoft Edge? I will reopen this issue for now.

@JasonGore JasonGore reopened this Feb 14, 2019
@aneeshack4
Copy link
Contributor

I just rewatched the screen capture video I made: https://microsoft-my.sharepoint-df.com/:u:/p/aneeshak/EZahg4_gVehHu48vES_mC6UBjD9ZjugJR2Yb6PN5Mc1p9w?e=g3XHlO and it looks like it was in Chrome so I don't think I tested this with Edge.

@aneeshack4
Copy link
Contributor

@TestAccessibilityGIT There are no details for Bug 5 in the spreadsheet - can you send a video/further details? (and please respond directly on github, not outlook because the Outlook comments make the issue unnecessarily long and hard to follow.)

@aneeshack4
Copy link
Contributor

@TestAccessibilityGIT I'm not able to repro Bug 4 either - when I use the arrows to reverse navigation, focus is not lost. (And this is all on Edge.) I have been trying make a video showing this non repro but Expression Encoder is no longer working on my machine. It's been very frustrating - if you know of any other free screen capture software that I can use for Narrator scenarios, please let me know.

@awalia13
Copy link

@aneeshack4 - Regarding Bug#5: This is the common issue we found across another control and we mentioned the column "Corresponding Bug ID" in the Bug 5 itself. So please refer the video for that bug.

@awalia13
Copy link

@aneeshack4 - Regarding Bug#4: We are still able to reproduce the bug and we tested with below platform and Version:

  • Microsoft Edge 44.18836.1000.0
  • Microsoft EdgeHTML 18.18836
  • OS Ver: 1903 (OS Build 18836.1000)

@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

@micahgodbolt
Copy link
Member

seems author has replied but bot didn't remove tag

@v-doku
Copy link

v-doku commented Feb 26, 2019

@JasonGore Could You please provide the Edge bug link which is raised for Bug 1 and 2 for our tracking.

@JasonGore
Copy link
Member

Please register and link your Github accounts with Microsoft organization so that we can share internal links and bug IDs with you.

@aneeshack4
Copy link
Contributor

aneeshack4 commented Mar 6, 2019

Tested the remaining 3 on Edge and yes they do repro but the reference example has the same behavior in Narrator Scan Mode and it's likely a byproduct of Bug 1 which is about Narrator Scan Mode not allowing slider value to change. External - Edge.

@v-doku
Copy link

v-doku commented Mar 6, 2019

@JasonGore have linked my account to Microsoft organization can you please share the bug link now.

@aneeshack4
Copy link
Contributor

Sent the Edge links on teams to @v-doku.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants