-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Component: Card #5322
Comments
This isn't a P1. But it's a feature we need. Let's prioritize |
Should Priority tags only be used for bugs? |
Do you have an ETA for this (and the Tile component) or should we find replacements in the interim? |
@kheide This hasn't been started yet, just a known gap in our component coverage. We're hoping to work on it in the coming month or so. |
Fantastic. Thanks! Also I just discovered the Chiclet component which sort of also helps. |
@mikewheaton making sure you're aware of this issue for tracking work on card. |
+1 |
@tenzin-copart just updated the description to better reflect current deadlines, but the short answer is that yes, there is a basic Work on this should start speeding up beginning next week and all related PRs will be linked to this issue. |
@khmakoto - Is this component ready now? |
Hi @tenzin-copart we have a prototype in its own |
hello @khmakoto any update on this ? Thanks |
Hi @Rtoribiog, the |
Since #9645 is on hold, are there any new plans now to introduce this into the main package? |
@Sentri How I can change styles if I clicked on card? I need use selector? |
@vitaliyKorzhenko yes, you do need to use a selector in that case. |
@khmakoto the compliance issue blocks us from using experimental API. What is the blocker or constraint that needs to be done in order to ship it? Thanks. |
Does Card respond to a Customizer yet? I tried setting some styles, and it didn't seem to change anything. I could be doing it wrong 🤷♂️
For now, I'm overriding the .ms-Card class as a workaround. |
Any updates on the cards getting merged in? |
@beeisabelm @jeffersoneagley we're currently in the process of revamping our components from many angles: bundle size, styling, API interface, etc. Card will be part of these components and that will hopefully remove any barriers for merging. We'll keep you updated on the process. |
I noticed they were just marked as deprecated. Should we be moving to a |
@jeffersoneagley like I mentioned in my comment above, we're currently in the process of revamping our components from many angles. I don't have an ETA yet for when |
Right, but it was just recently marked deprecated, and that's causing compliance issues for some people now. I don't want to go reinvent the wheel on it, but deprecated kind of implies there's something else I should be using. |
So I was very confused why Card is not available yet in fluentui... many of your components seem to use some form of a card like the DetailsList. Please can we get a basic Card version merged? |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
No bot, this is still an open question. |
We're working on a new version of the |
Component Details
A
Card
is a surface to display content and actions about a single topic. It acts as a container for actionable information like text, images and icons.A
Card
should abstract styling properties and utilize them in tandem with theme variables. Some of the properties to abstract are:Considerations and Design Decisions
There are a couple of things to consider and discuss regarding the implementation of a
Card
component. Some of these considerations are outlined below:compact
Card, which places the items in a row to use less screen space.Card
is responsive to screen size changes, but only within a limited range. A default minimum and maximum width are provided, with the ability to override this for custom scenarios.margins
andpadding
, and the component provides an easy way to opt out of this default behavior.Card
is clickable.Component Documentation
Imports
The
Stack
component is used to generate theCard
container.Exports/ Component Breakdown
Both the
Card
andCardItem
components are exported, as well as theCard
andCardItem
properties defined inCard.types
andCardItem.types
respectively.Intended Package
The component lives in a newly created
react-cards
package.Code mockup/example
Regular Card Example
Compact Card Example
Card Types
ICardSlots
root
IStackSlot
Card
.ICardProps
compact
boolean
false
Card
.onClick
(ev: React.MouseEvent<HTMLElement>) => void
ICardTokens
boxShadow
string
boxShadowHovered
string
childrenGap
number
|string
height
number
|string
maxWidth
number
|string
minHeight
number
|string
minWidth
number
|string
padding
number
|string
width
number
|string
Component Ownership
@khmakoto who will be creating the
Card
component.Deadlines
The initial basic
Card
container is expected to be finalized by April 2019, with further variants that may come in a foreseeable future.Related PRs
Card
component intoexperiments
packageCard
fromexperiments
packagereact-cards
package and migratingCard
component into itreact-cards
packageSteps
The text was updated successfully, but these errors were encountered: