Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card: Updating examples #8590

Merged
merged 6 commits into from
Apr 4, 2019
Merged

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Apr 3, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Updating Card examples to add a narrow card (fixed width) with its contents, clean some imports and remove the use of mergeStyleSets and gap.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Apr 3, 2019

Size Auditor did not detect a change in bundle size for any component!

@khmakoto khmakoto changed the title Card: Updating examples to show narrow card with contents Card: Updating examples Apr 3, 2019
@micahgodbolt micahgodbolt mentioned this pull request Apr 3, 2019
12 tasks
Copy link
Contributor

@cliffkoh cliffkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

@msft-github-bot msft-github-bot merged commit 2f4325c into microsoft:master Apr 4, 2019
@khmakoto khmakoto deleted the cardExamples branch April 4, 2019 07:51
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants