Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card: Adding vr-tests #9042

Merged
merged 2 commits into from
May 9, 2019
Merged

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented May 9, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Adding vr-tests for the Card component.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@micahgodbolt micahgodbolt mentioned this pull request May 9, 2019
12 tasks
@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@khmakoto
Copy link
Member Author

khmakoto commented May 9, 2019

@msft-github-bot wait 20 minutes

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 09 May 2019 23:09:13 GMT, which is in 20 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@msft-github-bot
Copy link
Contributor

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms) Is significant change Is regression
PrimaryButton 83.857 84.407 0.839 0.844 false false
BaseButton 34.679 35.397 0.347 0.354 false false
NewButton 112.429 118.139 1.124 1.181 true true
button 6.552 6.181 0.066 0.062 false false
DetailsRows without styles 197.936 188.171 1.979 1.882 false false
DetailsRows 210.865 211.461 2.109 2.115 false false
Toggles 52.756 54.059 0.528 0.541 false false
NewToggle 71.077 67.864 0.711 0.679 false false
DocumentCardTitle with truncation 28.884 28.362 0.289 0.284 false false

@msft-github-bot msft-github-bot merged commit ecd55b6 into microsoft:fabric-7 May 9, 2019
@khmakoto khmakoto deleted the cardsVRTests branch May 10, 2019 00:04
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants