-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card: Changing import of Stack to import from office-ui-fabric-react/lib/Stack given partner requests #8784
Conversation
…lib/Stack given partner requests.
Hello @khmakoto! Because this pull request has the Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here. |
Component perf results:
|
Size Auditor did not detect a change in bundle size for any component! |
@msft-github-bot wait for 1 hour and 30 minutes |
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
🎉 Handy links: |
Pull request checklist
$ npm run change
Description of changes
Partner teams are asking us to change the imports of
Stack
to import fromoffice-ui-fabric-react/lib/Stack
instead of fromoffice-ui-fabric-react
citing "webpack bugs int bundle mix which interferes with the correct importing ofoffice-ui-fabric-react
components". Given that the code still works the same with this change, I'm making it right now, with the intention to maintain communication and update later.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow