Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card: Changing import of Stack to import from office-ui-fabric-react/lib/Stack given partner requests #8784

Merged
merged 3 commits into from
Apr 19, 2019

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Apr 19, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Partner teams are asking us to change the imports of Stack to import from office-ui-fabric-react/lib/Stack instead of from office-ui-fabric-react citing "webpack bugs int bundle mix which interferes with the correct importing of office-ui-fabric-react components". Given that the code still works the same with this change, I'm making it right now, with the intention to maintain communication and update later.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@msft-github-bot
Copy link
Contributor

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms)
PrimaryButton 104.697 106.628 1.047 1.066
BaseButton 35.299 35.910 0.353 0.359
NewButton 124.684 118.173 1.247 1.182
button 5.134 5.006 0.051 0.050
DetailsRows without styles 197.719 193.780 1.977 1.938
DetailsRows 197.131 205.474 1.971 2.055
Toggles 50.000 53.684 0.500 0.537
NewToggle 65.591 69.733 0.656 0.697

@size-auditor
Copy link

size-auditor bot commented Apr 19, 2019

Size Auditor did not detect a change in bundle size for any component!

@khmakoto
Copy link
Member Author

@msft-github-bot wait for 1 hour and 30 minutes

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 19 Apr 2019 20:05:53 GMT, which is in 1 hour and 30 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@msft-github-bot msft-github-bot merged commit ea40fc4 into microsoft:master Apr 19, 2019
@khmakoto khmakoto deleted the stackImports branch April 19, 2019 20:21
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@micahgodbolt micahgodbolt mentioned this pull request Apr 25, 2019
12 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants