Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test:compat to CI tests #3691

Merged
merged 18 commits into from
May 19, 2021
Merged

chore: add test:compat to CI tests #3691

merged 18 commits into from
May 19, 2021

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented May 14, 2021 •
edited
Loading

Fixes #3632

Adds test:compat to CI. Should fail the CI test if api-extractor generates a diff.

Notes

  • Most of the ...api.md file diffs seem fine, but might be worth a closer look as there's a small number of public methods/interfaces that show diffs.
  • This only runs on node 10.x runs. This is roughly load-balanced since each node version in CI now runs two version-specific tasks.

For developers who stumbled here after your CI tests failed

  1. Fix errors
  2. yarn build
  3. Re-run yarn test:compat
  4. Find the new api.md in libraries/<failing lib>/temp and copy it to libraries/<failing lib>/etc, then commit the changes.

@mdrichardson
Copy link
Contributor Author

Hooray! The last build failed, just like it should.

@coveralls
Copy link

coveralls commented May 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 858282743

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.474%
Totals Coverage Status
Change from base Build 857757282: 0.2%
Covered Lines: 19239
Relevant Lines: 21416
💛 - Coveralls

@mdrichardson mdrichardson marked this pull request as ready for review May 15, 2021 00:36
@mdrichardson mdrichardson requested review from joshgummersall, stevengum and a team as code owners May 15, 2021 00:36
@mdrichardson mdrichardson merged commit 2894fd5 into microsoft:main May 19, 2021
@mdrichardson mdrichardson deleted the testCompat branch May 19, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test:compat to CI
3 participants
@mdrichardson @coveralls @joshgummersall