Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test:compat to CI #3632

Closed
mdrichardson opened this issue Apr 27, 2021 · 2 comments · Fixed by #3691
Closed

Add test:compat to CI #3632

mdrichardson opened this issue Apr 27, 2021 · 2 comments · Fixed by #3691
Assignees
@mdrichardson
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P2 Nice to have
Milestone
R14

Comments

@mdrichardson
Copy link
Contributor

Related: #3628 (comment)

Looks like it hasn't been updated in awhile, so it needs to be updated and also added to CI so that it stays up-to-date.
@mdrichardson mdrichardson added the Area: Adaptive The issue is related to Adaptive dialogs label Apr 27, 2021
@mdrichardson mdrichardson self-assigned this Apr 27, 2021
@joshgummersall
Copy link
Contributor

I think test:compat is a command across many packages. Perhaps it can be extracted to the root package.json file and run across all packages? The CI job ought to operate just like the test:schemas command in that it should run the command and fail if there's a diff detected.

@mdrichardson mdrichardson changed the title Add Adaptive's test:compat to CI Add test:compat to CI Apr 27, 2021
@mdrichardson mdrichardson removed the Area: Adaptive The issue is related to Adaptive dialogs label Apr 27, 2021
@mdrichardson
Copy link
Contributor Author

@joshgummersall Will do!

@joshgummersall joshgummersall added Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P2 Nice to have labels May 4, 2021
@joshgummersall joshgummersall added this to the R14 milestone May 4, 2021
@mdrichardson mdrichardson mentioned this issue May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdrichardson mdrichardson

Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P2 Nice to have
Projects
None yet
Milestone
R14
Development

Successfully merging a pull request may close this issue.

chore: add test:compat to CI tests mdrichardson/botbuilder-js
2 participants
@joshgummersall @mdrichardson