Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test:compat to CI tests #3691

Merged
merged 18 commits into from
May 19, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,7 @@ jobs:
- name: yarn test:schemas
if: matrix.node-version == '10.x'
run: yarn test:schemas

- name: yarn test:compat
if: matrix.node-version == '10.x'
joshgummersall marked this conversation as resolved.
Show resolved Hide resolved
run: yarn test:compat
3 changes: 1 addition & 2 deletions libraries/botbuilder-ai-orchestrator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@
"clean": "rimraf _ts3.4 lib tsconfig.tsbuildinfo",
"lint": "eslint . --ext .js,.ts",
"postbuild": "downlevel-dts lib _ts3.4/lib --checksum",
"test": "yarn build && nyc mocha tests/",
"test:compat": "api-extractor run --verbose"
"test": "yarn build && nyc mocha tests/"
mdrichardson marked this conversation as resolved.
Show resolved Hide resolved
},
"files": [
"_ts3.4",
Expand Down
362 changes: 322 additions & 40 deletions libraries/botbuilder-ai/etc/botbuilder-ai.api.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,17 @@ import { TelemetryPageView } from 'botbuilder-core';
import { TelemetryTrace } from 'botbuilder-core';
import { TurnContext } from 'botbuilder-core';

// @public (undocumented)
// @public
export class ApplicationInsightsTelemetryClient implements BotTelemetryClient, BotPageViewTelemetryClient {
constructor(connectionString: string);
constructor(instrumentationKey: string);
// (undocumented)
readonly configuration: appInsights.Configuration;
// (undocumented)
readonly defaultClient: appInsights.TelemetryClient;
// (undocumented)
get configuration(): appInsights.Configuration;
get defaultClient(): appInsights.TelemetryClient;
flush(): void;
// (undocumented)
trackDependency(telemetry: TelemetryDependency): void;
// (undocumented)
trackEvent(telemetry: TelemetryEvent): void;
// (undocumented)
trackException(telemetry: TelemetryException): void;
// (undocumented)
trackPageView(telemetry: TelemetryPageView): void;
// (undocumented)
trackTrace(telemetry: TelemetryTrace): void;
}

Expand All @@ -44,10 +37,11 @@ export const ApplicationInsightsWebserverMiddleware: any;
// @public
export class TelemetryInitializerMiddleware implements Middleware {
constructor(telemetryLoggerMiddleware: TelemetryLoggerMiddleware, logActivityTelemetry?: boolean);
protected appInsightsCorrelationContext: CorrelationContext;
readonly logActivityTelemetry: boolean;
protected set appInsightsCorrelationContext(value: CorrelationContext);
protected get appInsightsCorrelationContext(): CorrelationContext;
get logActivityTelemetry(): boolean;
onTurn(context: TurnContext, next: () => Promise<void>): Promise<void>;
readonly telemetryClient: TelemetryLoggerMiddleware;
get telemetryClient(): TelemetryLoggerMiddleware;
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ export class TelemetryInitializerMiddleware implements Middleware {
return this._telemetryLoggerMiddleware;
}

/**
* Sets the correlation context so that a mock context can be passed in for testing purposes.
*/
protected set appInsightsCorrelationContext(value: CorrelationContext) {
this._correlationContext = value;
}
Expand Down
3 changes: 1 addition & 2 deletions libraries/botbuilder-azure-blobs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
"clean": "rimraf _ts3.4 lib tsconfig.tsbuildinfo",
"lint": "eslint . --ext .js,.ts",
"postbuild": "downlevel-dts lib _ts3.4/lib --checksum",
"test": "yarn build && nyc mocha --check-leaks tests",
"test:compat": "api-extractor run --verbose"
"test": "yarn build && nyc mocha --check-leaks tests"
},
"files": [
"_ts3.4",
Expand Down
3 changes: 1 addition & 2 deletions libraries/botbuilder-azure-queues/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
"clean": "rimraf _ts3.4 lib tsconfig.tsbuildinfo",
"lint": "eslint . --ext .js,.ts",
"postbuild": "downlevel-dts lib _ts3.4/lib",
"test": "yarn build && nyc mocha --check-leaks tests",
"test:compat": "api-extractor run --verbose"
"test": "yarn build && nyc mocha --check-leaks tests"
},
"files": [
"_ts3.4",
Expand Down
19 changes: 6 additions & 13 deletions libraries/botbuilder-azure/etc/botbuilder-azure.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
```ts

import { Activity } from 'botbuilder';
import type { Agent } from 'http';
import { ConnectionPolicy } from 'documentdb';
import { CosmosClientOptions } from '@azure/cosmos';
import { PagedResult } from 'botbuilder';
Expand All @@ -14,7 +15,7 @@ import { StoreItems } from 'botbuilder';
import { TranscriptInfo } from 'botbuilder';
import { TranscriptStore } from 'botbuilder';

// @public
// @public @deprecated
export class AzureBlobTranscriptStore implements TranscriptStore {
constructor(settings: BlobStorageSettings);
deleteTranscript(channelId: string, conversationId: string): Promise<void>;
Expand All @@ -23,14 +24,11 @@ export class AzureBlobTranscriptStore implements TranscriptStore {
logActivity(activity: Activity): Promise<void>;
}

// @public
// @public @deprecated
export class BlobStorage implements Storage_2 {
constructor(settings: BlobStorageSettings);
// (undocumented)
delete(keys: string[]): Promise<void>;
// (undocumented)
read(keys: string[]): Promise<StoreItems>;
// (undocumented)
write(changes: StoreItems): Promise<void>;
}

Expand All @@ -53,40 +51,35 @@ export namespace CosmosDbKeyEscape {
// @public
export class CosmosDbPartitionedStorage implements Storage_2 {
constructor(cosmosDbStorageOptions: CosmosDbPartitionedStorageOptions);
// (undocumented)
delete(keys: string[]): Promise<void>;
initialize(): Promise<void>;
// (undocumented)
read(keys: string[]): Promise<StoreItems>;
// (undocumented)
write(changes: StoreItems): Promise<void>;
}

// @public
export interface CosmosDbPartitionedStorageOptions {
authKey: string;
authKey?: string;
compatibilityMode?: boolean;
containerId: string;
containerThroughput?: number;
cosmosClientOptions?: CosmosClientOptions;
cosmosDbEndpoint: string;
cosmosDbEndpoint?: string;
databaseId: string;
keySuffix?: string;
}

// @public @deprecated
export class CosmosDbStorage implements Storage_2 {
constructor(settings: CosmosDbStorageSettings, connectionPolicyConfigurator?: (policy: ConnectionPolicy) => void);
// (undocumented)
delete(keys: string[]): Promise<void>;
// (undocumented)
read(keys: string[]): Promise<StoreItems>;
// (undocumented)
write(changes: StoreItems): Promise<void>;
}

// @public @deprecated
export interface CosmosDbStorageSettings {
agent?: Agent;
authKey: string;
collectionId: string;
databaseCreationRequestOptions?: RequestOptions;
Expand Down
Loading