Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update taskparameters.ts #19022

Closed
wants to merge 7 commits into from
Closed

Update taskparameters.ts #19022

wants to merge 7 commits into from

Conversation

michelcedric
Copy link

Task name: AzureWebAppContainerV1

Description: support \n caracter for multiline
As some other Task (example : AzureFunctionAppV1) use appsettings parameter : Add multiline support.
I suggest to use \n as space (mandatory). It's better for readibility. A space is not visible and easy to forget it.
It's also more consistent with other tasks.

Documentation changes required: (N) => not required but maybe interesting to add information about this possibility

Added unit tests: (N)

Attached related issue: (N)

Checklist:

  • [ OK] Task version was bumped - please check instruction how to do it
  • [ OK] Checked that applied changes work as expected

Result

steps:
- task: AzureWebAppContainer@1
  displayName: 'Azure Web App on Container Deploy: test'
  inputs:
    azureSubscription: resourcegroup
    appName: test
    appSettings:  
      -input1 val1 \n
      -input2  val2 \n

@michelcedric
Copy link
Author

@v-mohithgc new one with updated version, and merged master.
Could you adapt this one or validated ?

@v-mohithgc
Copy link
Contributor

v-mohithgc commented Sep 27, 2023

@v-mohithgc new one with updated version, and merged master. Could you adapt this one or validated ?

Thanks, I will test it and update here.

@v-mohithgc
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@michelcedric
Copy link
Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 19022 in repo microsoft/azure-pipelines-tasks

@v-mohithgc
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-mohithgc
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-mohithgc
Copy link
Contributor

@michelcedric , looks the changes weren't build properly so checks are failing here, I will fix that now.
meanwhile, if possible, can you brief about the proposed fix here? like how to reproduce this issue (required for testing) and how these changes will fix that.

Thanks

@v-mohithgc
Copy link
Contributor

I have rebuild this task, will use this PR #19094

@michelcedric
Copy link
Author

Manually integrated in #19128
Thank you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants