Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support \n on appsetting for multiline #18652

Closed
wants to merge 0 commits into from
Closed

support \n on appsetting for multiline #18652

wants to merge 0 commits into from

Conversation

michelcedric
Copy link

@michelcedric michelcedric commented Jul 16, 2023

Task name: AzureWebAppContainerV1

Description: support \n caracter for multiline
As some other Task (example : AzureFunctionAppV1) use appsettings parameter : Add multiline support.
I suggest to use \n as space (mandatory). It's better for readibility. A space is not visible and easy to forget it.
It's also more consistent with other tasks.

Documentation changes required: (N) => not required but maybe interesting to add information about this possibility

Added unit tests: (N)

Attached related issue: (N)

Checklist:

  • [ OK] Task version was bumped - please check instruction how to do it
  • [ OK] Checked that applied changes work as expected

Result

steps:
- task: AzureWebAppContainer@1
  displayName: 'Azure Web App on Container Deploy: test'
  inputs:
    azureSubscription: resourcegroup
    appName: test
    appSettings:  
      -input1 val1 \n
      -input2  val2 \n

@michelcedric michelcedric requested a review from rvairavelu as a code owner July 16, 2023 15:34
@michelcedric
Copy link
Author

@dotnet-policy-service agree

@v-mohithgc
Copy link
Contributor

Hi @michelcedric , thanks for contributing.

We are currently checking these changes, since the task version here is outdated, I will create a new PR with similar changes and build it.
I will update the PR link here once its ready.

@michelcedric
Copy link
Author

@v-mohithgc I created a new one ;)
#19022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants