Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureWebAppContainerV1: Add multiline support #19128

Merged

Conversation

v-mohithgc
Copy link
Contributor

@v-mohithgc v-mohithgc commented Oct 17, 2023

Task name: AzureWebAppContainerV1

Description: support \n caracter for multiline
As some other Task (example : AzureFunctionAppV1) use appsettings parameter : Add multiline support.
I suggest to use \n as space (mandatory). It's better for readibility. A space is not visible and easy to forget it.
It's also more consistent with other tasks.

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related PR: (Y/N) #19022

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Copy link
Contributor

@v-nagarajku v-nagarajku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-mohithgc v-mohithgc merged commit bf37f3e into microsoft:master Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants