Add Microsoft Go support #19000
Add Microsoft Go support #19000
Conversation
v-mohithgc
requested review from
rvairavelu and
manolerazvan
as code owners
|
thx a ton for working through this! |
There was a problem hiding this comment.
Sorry I'm late to the party--I have concerns about making this a simple dropdown. For context, in #16045 I mentioned:
We don't want to change the default base URL: Azure Pipelines users outside Microsoft should continue to get the official Go binaries. (Our build of Go is only intended for use within Microsoft to meet supply chain and FIPS requirements. For more info, the Microsoft build of Go is maintained at https://github.com/microsoft/go.)
Based on the screenshot and PR it doesn't look like there's any way for a user who sees this option to get more context about what the MS Go Tools option does. Without context, I worry that this will show up to anyone using AzDO (whether internal or not) and people will choose this just because it says "MS", not knowing what it's for and not needing it. This might result in spurious issues being filed (on this repo and ours) because e.g. this option doesn't support the same set of platforms as official Go.
If any of that is wrong or not a concern for a reason I haven't thought about, please let me know. 🙂
I prefer a raw URL input because then the user needs to already know what our toolset is for and very intentionally use it. This also avoids preferential treatment towards our fork of Go--with a URL, anyone could set up their own fork of Go and use that with this task.
The microsoft/go project might change to actually wanting to "advertise" our fork with dropdowns like this in the future, but so far that doesn't fit our goals.
| @@ -33,7 +33,7 @@ | |||
| "name": "version", | |||
| "type": "string", | |||
| "label": "ms-resource:loc.input.label.version", | |||
| "defaultValue": "1.10", | |||
| "defaultValue": "1.19", | |||
There was a problem hiding this comment.
Go 1.21 was released on Aug 8 (after PR #18681), which means 1.19 is now EOL. 1.20 is now the oldest supported major version, so:
| "defaultValue": "1.19", | |
| "defaultValue": "1.20", |
| } | ||
| // Is there a safe way to allow fully custom URLs? How would we create the cache key? | ||
| if (goSourceInput != defaultSource && goSourceInput != microsoftSource) { | ||
| throw new Error('Only google and Microsoft sources are allowed') |
There was a problem hiding this comment.
Consistent capitalization?
| throw new Error('Only google and Microsoft sources are allowed') | |
| throw new Error('Only Google and Microsoft sources are allowed') |
This reverts commit 3d8da00.
|
I submitted a revert PR here: #19012. Sorry I didn't get a chance to review this before it was merged, or when the dropdown was originally discussed. |
* Revert "Added Microsoft Go tool support (#19000)" This reverts commit 3d8da00. * Update GoToolV0 to 0.229.1 * Update GoToolV0 to 0.229.1 in task.loc.json --------- Co-authored-by: Mohith <[email protected]>
Task name: GoToolV0
Description: Clone of #18681: Add a goSource parameter to allow use of the Microsoft Go tool and default Go tools
Checklist: