Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added Microsoft Go tool support (#19000)" #19012

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

dagood
Copy link
Member

@dagood dagood commented Sep 22, 2023

This reverts commit 3d8da00 (PR #19000)

Task name: GoToolV0

Description: The effort is appreciated, but the microsoft/go team has concerns about using a dropdown--see #19000 (review).

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

/cc @ozanaydinMSFT @shueybubbles @v-mohithgc @rvairavelu @manolerazvan @LeftTwixWand

@dagood
Copy link
Member Author

dagood commented Sep 22, 2023

I think after merging this, #18681 could be reopened? I'm not sure if it was considered ready to go or still needed some work.

@dagood dagood mentioned this pull request Sep 22, 2023
2 tasks
@v-mohithgc
Copy link
Contributor

v-mohithgc commented Sep 25, 2023

Hi @dagood please bump the minor version to 229 and patch to 1 (ie 0.229.1), will proceed to merge this PR.
Thanks

@shueybubbles
Copy link

@v-mohithgc if you can revive #18681 it should achieve the goal. thx!

@dagood
Copy link
Member Author

dagood commented Sep 25, 2023

@v-mohithgc I've added the version bump, thanks.

@v-mohithgc
Copy link
Contributor

@v-mohithgc I've added the version bump, thanks.

Thanks, can you please bump the version (0.229.1) in task-loc.json as well.

@v-mohithgc
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-mohithgc
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-mohithgc v-mohithgc merged commit 3cac0cb into microsoft:master Sep 29, 2023
@dagood dagood deleted the dev/dagood/revert-go-dropdown branch September 29, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants