Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoTool] Make the Go download URL configurable #16045

Closed
dagood opened this issue Mar 17, 2022 · 6 comments
Closed

[GoTool] Make the Go download URL configurable #16045

dagood opened this issue Mar 17, 2022 · 6 comments

Comments

@dagood
Copy link
Member

dagood commented Mar 17, 2022

Required Information

Type: Feature
Task Name: GoTool

Environment

  • Azure Pipelines, any version used in Microsoft internal builds
  • Agent - any

Issue Description

My team is building Go for internal use at Microsoft, but we don't have a good way for people who use the GoTool@0 task to switch over from the official build of Go to our build of Go. I think all we need is a way to configure the base URL rather than hard coding it:

function getDownloadUrl(filename: string): string {
return util.format("https://storage.googleapis.com/golang/%s", filename);
}

URLs for our builds will be something like https://aka.ms/golang/release/%s.

We don't want to change the default base URL: Azure Pipelines users outside Microsoft should continue to get the official Go binaries. (Our build of Go is only intended for use within Microsoft to meet supply chain and FIPS requirements. For more info, the Microsoft build of Go is maintained at https://github.com/microsoft/go.)

Task logs

N/A

Troubleshooting

N/A

Error logs

N/A

@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Sep 13, 2022
@dagood
Copy link
Member Author

dagood commented Sep 13, 2022

Commenting to prevent closure as stale. Issue is awaiting a response from repo maintainers.

@github-actions github-actions bot removed the stale label Sep 14, 2022
@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Mar 13, 2023
@dagood
Copy link
Member Author

dagood commented Mar 15, 2023

Commenting to prevent closure as stale. Issue is awaiting a response from repo maintainers.

@github-actions github-actions bot removed the stale label Mar 15, 2023
@shueybubbles
Copy link

I think it will also need a modification to the cache logic to use the source URL in the key

Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants