Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audio-feedback): Add sound feedback when starting and stopping "tab stops" test #1851

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

codeofdusk
Copy link
Contributor

Details

Similar to that implemented for event recording, this PR adds an audio cue when the tab stops test is toggled and "provide feedback with sound" is enabled.

Motivation

Addresses #1833.

Context

This PR does duplicate a small quantity of code, but this is not unprecedented for the project.

Pull request checklist

@codeofdusk codeofdusk requested a review from a team as a code owner September 27, 2024 17:14
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared with #1525 and LGTM!

@codeofdusk codeofdusk changed the title fix: Add sound feedback when starting and stopping "tab stops" test feat(audio-feedback): Add sound feedback when starting and stopping "tab stops" test Sep 27, 2024
@codeofdusk codeofdusk merged commit a0d3ba9 into microsoft:main Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants