Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Tab stops: when starting or stopping recording and "provide feedback with sound" is enabled, no sound plays #1833

Closed
codeofdusk opened this issue Jun 4, 2024 · 2 comments
Closed

[BUG] Tab stops: when starting or stopping recording and "provide feedback with sound" is enabled, no sound plays #1833

codeofdusk opened this issue Jun 4, 2024 · 2 comments
Assignees
@codeofdusk
Labels
bug Something isn't working status: ready for work This issue is ready to be worked on.

Comments

@codeofdusk
Copy link
Contributor

codeofdusk commented Jun 4, 2024 •
edited
Loading

Please check whether the bug has already been filed.

This repo contains code for Accessibility Insights for Windows. We maintain code for its automated checks rule engine at axe-windows. Most false positive questions or rule clarifications belong in axe-windows, whereas questions about the Accessibility Insights tool UI should go here. If you aren't sure, it's definitely OK to use this repo. Thanks for contributing!

Describe the bug
We added new start and stop sounds for event recording, but these don't play when starting and stopping tab stops, making it harder for screen reader users to know whether tab stops is running.

To Reproduce

  1. Enable "provide feedback with sound" in settings, or leave it on "automatic" and set the screen reader flag.
  2. Test an app (set focus, then Shift+F8).
  3. Go to the "tab stops" tab.
  4. Set focus to the app again, and Shift+F7.

Expected behaviour
Sound feedback plays

Actual behaviour
Nothing happens

Admittedly, I think sound feedback here would be of little utility, since tab stops is mostly a visual aid anyway.
@codeofdusk codeofdusk added the bug Something isn't working label Jun 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Jun 4, 2024
@codeofdusk codeofdusk added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jun 4, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the status: new This issue is new and requires triage by DRI. label Jun 4, 2024
@brocktaylor7 brocktaylor7 added status: ready for work This issue is ready to be worked on. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Jun 24, 2024
@brocktaylor7 brocktaylor7 moved this from Needs triage to Accepted in Accessibility Insights Jun 24, 2024
@codeofdusk codeofdusk assigned codeofdusk and unassigned nang4ally Sep 27, 2024
@codeofdusk codeofdusk mentioned this issue Sep 27, 2024
Merged
1 task
codeofdusk added a commit that referenced this issue Sep 27, 2024
@codeofdusk
feat(audio-feedback): Add sound feedback when starting and stopping "…
a0d3ba9 
…tab stops" test (#1851)

Similar to that implemented for event recording, this commit adds an audio
cue when the tab stops test is toggled and "provide feedback with sound"
is enabled.

This commit does duplicate a small quantity of code, but this is not
unprecedented for the project.

Addresses #1833.
@codeofdusk
Copy link
Contributor Author

Closed in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeofdusk codeofdusk

Labels
bug Something isn't working status: ready for work This issue is ready to be worked on.
Projects
Accessibility Insights
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeofdusk @brocktaylor7 @nang4ally