Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audio-feedback): Play sounds when toggling event recording #1525

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Jan 12, 2023

Details

This PR adds functionality for playing sounds on starting/stopping event recording when sound feedback is enabled.

Motivation

Closes #1440.

Context
  • When rapidly pressing Shift+F7, there may be some delay in sound playback as event recording takes a moment to toggle in some circumstances.

Pull request checklist

Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge.

@codeofdusk codeofdusk requested a review from a team as a code owner January 12, 2023 10:42
Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound files are not included in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Report to screen reader users when event recording starts and stops
2 participants