fix: replace hardcoded checked/ unchecked names with toggle pattern #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
reviewed
Jan 13, 2023
src/AccessibilityInsights.SharedUx/Controls/CustomControls/ToggleMenuItemAutomationPeer.cs
Show resolved
Hide resolved
DaveTryon
approved these changes
Jan 13, 2023
This was referenced Jan 13, 2023
sfoslund
added a commit
that referenced
this pull request
Jan 19, 2023
#### Details Expand on fix in #1529. I found another set of radio buttons which were not properly announcing their state/ implementing the toggle pattern. This PR leverages with ToggleMenuItem control added in #1529 to ensure that checked/ unchecked states are announced. Steps to repro: - Live inspect any app with AI win - Go to "More options" and "listen to events" - Select event settings button (beside recording button) - Expand "Event recording scope" menu item and observe 3 radio buttons that do not announce their state to screenreaders ##### Motivation Address another instance of improper implementation of UIA patterns that was missed in #1514 #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Run through of all [test scenarios](https://github.com/Microsoft/accessibility-insights-windows/blob/main/docs/Scenarios.md) completed? - [n/a] Does this address an existing issue? If yes, Issue# - - [n/a] Includes UI changes? - [ ] Run the production version of Accessibility Insights for Windows against a version with changes. - [ ] Attach any screenshots / GIF's that are applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes the checked/ unchecked instances in #1514
Motivation
Addresses issue #1514
Context
While checking that this did not disrupt any existing styling, I noticed/ filed #1528 to be addressed separately.
Pull request checklist