Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Hierarchy settings menu does not honor dark mode #1528

Closed
sfoslund opened this issue Jan 12, 2023 · 4 comments
Closed

[BUG] Hierarchy settings menu does not honor dark mode #1528

sfoslund opened this issue Jan 12, 2023 · 4 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main.

Comments

@sfoslund
Copy link
Member

Describe the bug
Hierarchy settings menu does not honor dark mode

To Reproduce
Steps to reproduce the behavior:

  1. Open AIWin in dark mode
  2. Live inspect any app
  3. Click Settings icon at top right of left panel
  4. See hierarchy settings menu is in light mode

Expected behavior
Entire app adheres to dark mode setting

Actual behavior
Hierarchy settings menu remains in light mode

Screenshots or .GIF

[Description: Screenshot of AI win in dark mode, with hierarchy settings menu open and still in light mode]
AIWinDarkModeSettings

Desktop (please complete the following information):

  • OS: Windows 11 22621
  • Accessibility Insights for Windows Version: Current prod (1.1.2089.1)
  • Target Application: Wildlife Manager
  • Target Application Version: 2.0
@sfoslund sfoslund added the bug Something isn't working label Jan 12, 2023
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Jan 12, 2023
@ghost ghost assigned jlperkins Jan 12, 2023
@jlperkins
Copy link

Repro'd, thanks for finding this Sarah!

@jlperkins jlperkins added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Jan 12, 2023
@ghost ghost assigned asksep Jan 12, 2023
@ghost
Copy link

ghost commented Jan 12, 2023

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@sfoslund sfoslund mentioned this issue Jan 12, 2023
Merged
4 tasks
sfoslund added a commit that referenced this issue Jan 13, 2023
@sfoslund
fix: replace hardcoded checked/ unchecked names with toggle pattern (#…
f750072 
…1529)

#### Details

Fixes the checked/ unchecked instances in
#1514

##### Motivation

Addresses issue
#1514

##### Context

While checking that this did not disrupt any existing styling, I
noticed/ filed
#1528
to be addressed separately.

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->

- [ ] Run through of all [test
scenarios](https://github.com/Microsoft/accessibility-insights-windows/blob/main/docs/Scenarios.md)
completed?
- [x] Does this address an existing issue? If yes,
#1514
- [n/a] Includes UI changes?
- [ ] Run the production version of Accessibility Insights for Windows
against a version with changes.
  - [ ] Attach any screenshots / GIF's that are applicable.
@sfoslund
Copy link
Member Author

It looks like we have the same issue with the event settings menu as well:

[Image description: screenshot of AI win event settings menu open in dark mode, menu is still light grey]
EventSettingsNotDarkMode

@sfoslund sfoslund mentioned this issue Jan 23, 2023
Merged
5 tasks
@sfoslund sfoslund added status: active This issue is currently being worked on by someone. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Jan 23, 2023
sfoslund added a commit that referenced this issue Feb 27, 2023
@sfoslund
fix: Add dark mode styling for nested menu items (#1543)
de118c3 
#### Details

Update styling for menu items such that they adhere to dark mode. This
effects the hierarchy settings and event settings menus that were
identified in
#1528.

##### Motivation

Addresses issue
#1528

##### Context

[Image grid description: Screenshots of each menu before and after the
styling change in dark and light modes]
| | Before | After |
| - | ------- | ------ |
| Hierarchy settings in light mode | <img width="667"
alt="light-livesettings-before"
src="https://user-images.githubusercontent.com/16010855/214106081-7250b713-ff0b-43c3-94a2-7306e595333b.png">
| <img width="667" alt="Light-livesettings-after"
src="https://user-images.githubusercontent.com/16010855/214106022-723384d7-d4a5-465e-88bb-52b0a8a581bb.png">
|
| Hierarchy settings in dark mode | <img width="667"
alt="dark-livesettings-before"
src="https://user-images.githubusercontent.com/16010855/214106294-884ec43b-5423-474f-97a6-574f942e7941.png">
| <img width="667" alt="dark-livesettings-after"
src="https://user-images.githubusercontent.com/16010855/214106246-c665eb5d-3f27-4417-b109-b334030c9b85.png">
|
| Event settings in light mode | <img width="667"
alt="light-eventsettings-before"
src="https://user-images.githubusercontent.com/16010855/214105995-47f35f87-6bba-4971-a440-81627f1269e3.png">
| <img width="667" alt="light-eventsettings-after"
src="https://user-images.githubusercontent.com/16010855/214105948-ad6312a3-9726-42a5-9e2b-4f02c94b1789.png">
|
| Event settings in dark mode | <img width="667"
alt="dark-eventsettings-before"
src="https://user-images.githubusercontent.com/16010855/214106217-becac53f-4082-49c0-a8ba-d0e0767891e3.png">
| <img width="667" alt="dark-eventsettings-after"
src="https://user-images.githubusercontent.com/16010855/214106188-12ca3269-73e4-4e19-a8ef-c8c639ef4de8.png">
|

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->

- [ ] Run through of all [test
scenarios](https://github.com/Microsoft/accessibility-insights-windows/blob/main/docs/Scenarios.md)
completed?
- [x] Does this address an existing issue? If yes,
#1528
- [x] Includes UI changes?
- [ ] Run the production version of Accessibility Insights for Windows
against a version with changes.
  - [x] Attach any screenshots / GIF's that are applicable.
@DaveTryon DaveTryon added status: resolved This issue has been merged into main. and removed status: active This issue is currently being worked on by someone. labels Mar 31, 2023
@DaveTryon
Copy link
Contributor

This has been fixed in Canary since release 1.1.2249.01. Closing the issue as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: resolved This issue has been merged into main.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sfoslund @asksep @jlperkins @DaveTryon