Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dark mode menu overtheming in TextPattern Explorer #1609

Closed
DaveTryon opened this issue May 5, 2023 · 4 comments
Closed

[BUG] Dark mode menu overtheming in TextPattern Explorer #1609

DaveTryon opened this issue May 5, 2023 · 4 comments
Labels
bug Something isn't working resolution: out of scope This issue has been identified as out of scope for this project.

Comments

@DaveTryon
Copy link
Contributor

DaveTryon commented May 5, 2023

Describe the bug
The TextPattern explorer doesn't respond to dark mode theming, but the context menus are themed. In Prod, only the settings menus are themed; In Canary, the "..." context menu is also themed (this last change was caused by #1529).

To Reproduce
Steps to reproduce the behavior:

  1. Set your system to dark mode
  2. Run AIWin
  3. Open the Text Explorer dialog
  4. Click on the ... button or either of the gear buttons

Expected behavior
Context menus in unthemed dialogs should probably also be unthemed--they look a bit odd when they're mixed.

Actual behavior
The ideal (but unlikely) fix would be to theme the dialogs that are currently unthemed. Probably the more realistic fix would be to have an unstyled theme for context menus and use that from all unstyled dialogs.

Screenshots or .GIF

Menu Image
Range Settings image
Attribute Settings image
Text Settings image

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11 22H2
  • Accessibility Insights for Windows Version: 1.1.2312.1

Additional context
Priority requested -
Add any other context about the problem here.

@DaveTryon DaveTryon added the bug Something isn't working label May 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label May 5, 2023
@DaveTryon DaveTryon added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels May 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@DaveTryon DaveTryon removed their assignment May 5, 2023
@dbjorge
Copy link
Contributor

dbjorge commented May 16, 2023

Note: we'd like to attempt the harder version of the fix (make the dialog(s) dark-mode compatible), but try to do it within a time box

@dbjorge dbjorge added the status: ready for work This issue is ready to be worked on. label May 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 16, 2023
@DaveTryon
Copy link
Contributor Author

Upon further investigation, this is significantly more work than we are prepared to invest at this time. WPF does not provide a good way to theme the dialog caption bar, and carrying the full theming through all of the actions and properties dialogs is something that does not fit into our current prioritized backlog. We're going to close this and leave it as is.

@DaveTryon DaveTryon added resolution: out of scope This issue has been identified as out of scope for this project. and removed status: ready for work This issue is ready to be worked on. labels Jun 26, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as being beyond the support scope of Accessibility Insights. It will now be closed automatically for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolution: out of scope This issue has been identified as out of scope for this project.
Projects
None yet
Development

No branches or pull requests

3 participants