-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transforms] Merge master 07/11 into transform #9697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore casing when converting a source file path to relative path
Add glob-style file include pattern support for tsconfig.json
export interface used by other exported functions
…nt base indentations. Use the base indent size if it is greater that the indentation of the inherited predecessor
…thods-returning-this Provide a symbol for salsa-inferred class types
Fix #9542 (allow files under node_modules to be included in the compilation).
Update conflicting baseline.
# Conflicts: # src/compiler/checker.ts # src/compiler/commandLineParser.ts # src/compiler/core.ts # src/compiler/diagnosticMessages.json # src/compiler/emitter.ts # src/compiler/parser.ts # src/compiler/program.ts # src/compiler/scanner.ts # src/compiler/sys.ts # src/compiler/tsconfig.json # src/compiler/types.ts # src/compiler/utilities.ts # src/harness/fourslash.ts # src/harness/harness.ts # src/harness/harnessLanguageService.ts # src/harness/loggedIO.ts # src/harness/projectsRunner.ts # src/lib/dom.generated.d.ts # src/lib/webworker.generated.d.ts # src/services/navigationBar.ts # src/services/tsconfig.json # tests/baselines/reference/decoratorMetadataWithImportDeclarationNameCollision4.js # tests/baselines/reference/transpile/Rename dependencies - System.js # tests/baselines/reference/transpile/Rename dependencies - UMD.js # tests/baselines/reference/transpile/Sets module name.js # tests/baselines/reference/transpile/Transpile with emit decorators and emit metadata.js # tests/baselines/reference/tsxUnionTypeComponent2.js # tests/cases/fourslash/fourslash.ts # tests/cases/fourslash/referencesInComment.ts # tests/cases/unittests/cachingInServerLSHost.ts # tests/cases/unittests/jsDocParsing.ts # tests/cases/unittests/matchFiles.ts # tests/cases/unittests/transpile.ts
All tests failure related to classExpression which contains capturing static property |
👍 |
@@ -3239,14 +3214,14 @@ namespace ts { | |||
} | |||
|
|||
function trySubstituteDecoratedClassName(node: Identifier): Expression { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to rename this function since it is not just decorated class name anynmore
👍 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master into transforms 🎉 There are tests related to
classExpressionWithStaticProperties
that fail. This require this PR @rbucktonshould I just accept baselines for now as we already has issue to track this problem?Interesting commit starts from dd0cd58
TODO: