Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export interface used by other exported functions #9286

Merged
merged 1 commit into from
Jun 21, 2016
Merged

export interface used by other exported functions #9286

merged 1 commit into from
Jun 21, 2016

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Jun 21, 2016

Refs an NTypeScript build failure : https://travis-ci.org/TypeStrong/ntypescript#L332 🌹

@DanielRosenwasser DanielRosenwasser merged commit cb9246f into microsoft:master Jun 21, 2016
@DanielRosenwasser
Copy link
Member

Thanks @basarat! @mhegazy do you have any clue why the build doesn't fail for us when something like this happens?

@basarat
Copy link
Contributor Author

basarat commented Jun 21, 2016

when something like this

To be clear its because I don't strip internal for ntypescript (unlike typescript) as I use / experiment with them quite frequently 🌹

@basarat basarat deleted the patch-2 branch June 21, 2016 06:57
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basarat @DanielRosenwasser @msftclas