ignore casing when converting a source file path to relative path #9213
Conversation
| @@ -2330,7 +2330,9 @@ namespace ts { | |||
|
|
|||
| export function getSourceFilePathInNewDir(sourceFile: SourceFile, host: EmitHost, newDirPath: string) { | |||
| let sourceFilePath = getNormalizedAbsolutePath(sourceFile.fileName, host.getCurrentDirectory()); | |||
| sourceFilePath = sourceFilePath.replace(host.getCommonSourceDirectory(), ""); | |||
| const commonSourceDirectory = host.getCommonSourceDirectory(); | |||
| const isSourceFileInCommonSourceDirectory = sourceFilePath.toLowerCase().indexOf(commonSourceDirectory.toLowerCase()) === 0; | |||
There was a problem hiding this comment.
This shouldn't be done without checking ignoreCase option in compilerOptions
There was a problem hiding this comment.
I only found a forceConsistentCasingInFileNames option in the compilerOptions. Is that what you are referring to?
There was a problem hiding this comment.
Meant usage of getCanonicalFileName instead to handle the casing option just like the way we do in relative name computation or common directory name compuation.
There was a problem hiding this comment.
The case sensitivity used by getCanonicalFileName is actually not very trustable, because we tell the file system case sensitivity solely by OS. However, in some cases this is wrong, for example network mounted file system on Windows, or HFS / HFS+ on OSX. Relying on it has caused many troubles previously when dealing with file watching. So I think it might be better if we only use the canonical file name internally for comparison purpose, but not when directly talking to the file system.
|
👍 |
Fixes #8837
When converting an absolute file name to a relative file name, sometimes the
commonSourceDirectoryand the absolute file name have different casing, which should be ignored.