Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IT DateTimeV2] Fix for time expression [minutes] minuti alle [hour] #3067

Merged
merged 21 commits into from
Mar 3, 2023
Merged

[IT DateTimeV2] Fix for time expression [minutes] minuti alle [hour] #3067

merged 21 commits into from
Mar 3, 2023

Conversation

andrew-gradinari
Copy link
Contributor

Fix for Italian time expressions such as "5 minuti alle quattro".

References: Time in Italian

tellarin and others added 20 commits March 25, 2022 16:35
@tellarin @Conor-Keaney
[ES Temperature] Support informal degrees and fix issue in ES auto-ge…
73b8241 
…n for Units (microsoft#2877) (microsoft#2879)

- Support informal degrees in PT and ES (microsoft#2877);

- Fix issue in generation of Spanish unit resources;

- Re-generate all resources across platforms.
@colm-dillon @Conor-Keaney
[Python] Enabling SpanishMexican culture in Number/Unit/DateTimveV2 (m…
365d66f 
…icrosoft#2878)

* Enabling SpanishMexican culture in Number/Unit/DateTimveV2

* Update Spanish number specs according to review

Co-authored-by: Colm Dillon <[email protected]>
@samhickey25 @Conor-Keaney
[Python] Add Portuguese support for DateTimeV2 (microsoft#2876)
ff11e07 
* Add Portuguese DateTime support in Python

* Update Specs with Python changes

* Fix Number import issue

* Update specs according to build and review

* Remove empty NotSupported fields from specs
@aitelint @Conor-Keaney
[KO Number] Fixed incorrect extraction of number from datetime mention (
3e520e5 
microsoft#2863) (microsoft#2892)

Co-authored-by: aitelint <[email protected]>
@shana @Conor-Keaney
[.NET Timexlib] Fix timex-to-string conversion of English ordinals 11…
f703254 
…-13 (microsoft#2896)
@shana @Conor-Keaney
[EN .NET] Workaround for TimexProperty.ToString() to not crash on Dat…
45b0c3b 
…eTimeRanges (microsoft#2894)

* Workaround for TimexProperty.ToString() to not crash on DateTimeRanges 

* Add TODO for fixing the TimexProperty date range representation properly according to review
Merge pull request #24 from microsoft/master
d6e3692 
Fetch microsoft/Recognizers-Text upstream changes
Merge pull request #29 from microsoft/master
30dbdaf 
[NLU-2858] Fetch upstream changes from microsoft:master -> purecloudlabs:master
@samhickey25
Merge pull request #33 from microsoft/master
3a2342a 
Merge MS Recognizers into master
@kevinwalshgen
Merge pull request #37 from microsoft/master
cd9ba48 
Bringing Pureclould Labs master up to-date with Microsoft master
@kevinwalshgen
NLU-2966: Fix failing tests
22f56fd
@kevinwalshgen
Revert "NLU-2966: Fix failing tests"
c544eff 
This reverts commit 22f56fd.
@samhickey25
Merge pull request #42 from microsoft/master
8f92c9a 
Update fork with MS recognizers latest
@samhickey25
Merge branch 'microsoft:master' into master
f14677d
@rbrennangen
Merge branch 'microsoft:master' into master
d631cbe
@rbrennangen
Merge branch 'microsoft:master' into master
a830707
@rbrennangen
Merge branch 'microsoft:master' into master
e378aa3
@Conor-Keaney
Merge branch 'microsoft:master' into master
86f14b8
@samhickey25
Merge pull request #53 from microsoft/master
4451a53 
Sync Fork
@andrew-gradinari
[IT DateTimeV2] Fix for time expression [minutes] minuti alle [hour]
f668e5c
@andrew-gradinari
Copy link
Contributor Author

Hello @tellarin, could you please take a look at this pull request as well as #3061, #3063, #3065, and #3066? Thank you in advance.

@tellarin
Copy link
Collaborator

tellarin commented Feb 9, 2023

@andrew-gradinari Thanks for the ping. We'll review them shortly.

tellarin
tellarin requested changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@tellarin tellarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a couple examples of the new behaviour at the model level (DateTimeModel.json) too? This is critical to show the final output is correct.
Also, it would be good if you can add other examples using "e|meno" in other scenarios to show no behaviour there was broken with the change. If such examples already exist, please mention it in the PR description.

@andrew-gradinari
Copy link
Contributor Author

@tellarin There are some examples using "e|meno":

TimeExtractor.json

Recognizers-Text/Specs/DateTime/Italian/TimeExtractor.json

Lines 195 to 324 in b80b58c

"Input": "Sono le otto e mezza",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e mezza",
"Type": "time",
"Start": 8,
"Length": 12
}
]
},
{
"Input": "Sono le 8 e mezza pm",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "8 e mezza pm",
"Type": "time",
"Start": 8,
"Length": 12
}
]
},
{
"Input": "Sono le otto e 30 min",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e 30 min",
"Type": "time",
"Start": 8,
"Length": 13
}
]
},
{
"Input": "Sono le otto e un quarto",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e un quarto",
"Type": "time",
"Start": 8,
"Length": 16
}
]
},
{
"Input": "Sono le 9pm e tre quarti",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "9pm e tre quarti",
"Type": "time",
"Start": 8,
"Length": 16
}
]
},
{
"Input": "Sono le otto meno tre minuti",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto meno tre minuti",
"Type": "time",
"Start": 8,
"Length": 20
}
]
},
{
"Input": "Sono le sette e mezza",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "sette e mezza",
"Type": "time",
"Start": 8,
"Length": 13
}
]
},
{
"Input": "Sono le sette e mezza di pomeriggio",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "sette e mezza di pomeriggio",
"Type": "time",
"Start": 8,
"Length": 27
}
]
},
{
"Input": "Sono le sette e mezza del mattino",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "sette e mezza del mattino",
"Type": "time",
"Start": 8,
"Length": 25
}
]
},
{
"Input": "Sono le 8 meno un quarto del mattino",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "8 meno un quarto del mattino",
"Type": "time",
"Start": 8,
"Length": 28
}
]
},
{
"Input": "Sono le otto e un quarto di sera",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e un quarto di sera",
"Type": "time",
"Start": 8,
"Length": 24
}
]

TimeParser.json

Recognizers-Text/Specs/DateTime/Italian/TimeParser.json

Lines 444 to 673 in b80b58c

"Input": "Sono le otto e mezza",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e mezza",
"Type": "time",
"Value": {
"Timex": "T08:30",
"FutureResolution": {
"time": "08:30:00"
},
"PastResolution": {
"time": "08:30:00"
}
},
"Start": 8,
"Length": 12
}
]
},
{
"Input": "Sono le 8 e mezza pm",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "8 e mezza pm",
"Type": "time",
"Value": {
"Timex": "T20:30",
"FutureResolution": {
"time": "20:30:00"
},
"PastResolution": {
"time": "20:30:00"
}
},
"Start": 8,
"Length": 12
}
]
},
{
"Input": "Sono le otto e 30 min",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e 30 min",
"Type": "time",
"Value": {
"Timex": "T08:30",
"FutureResolution": {
"time": "08:30:00"
},
"PastResolution": {
"time": "08:30:00"
}
},
"Start": 8,
"Length": 13
}
]
},
{
"Input": "Sono le otto e un quarto",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e un quarto",
"Type": "time",
"Value": {
"Timex": "T08:15",
"FutureResolution": {
"time": "08:15:00"
},
"PastResolution": {
"time": "08:15:00"
}
},
"Start": 8,
"Length": 16
}
]
},
{
"Input": "Sono le 9pm e tre quarti",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "9pm e tre quarti",
"Type": "time",
"Value": {
"Timex": "T21:45",
"FutureResolution": {
"time": "21:45:00"
},
"PastResolution": {
"time": "21:45:00"
}
},
"Start": 8,
"Length": 16
}
]
},
{
"Input": "Sono le otto meno tre minuti",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto meno tre minuti",
"Type": "time",
"Value": {
"Timex": "T07:57",
"FutureResolution": {
"time": "07:57:00"
},
"PastResolution": {
"time": "07:57:00"
}
},
"Start": 8,
"Length": 20
}
]
},
{
"Input": "Sono le sette e mezza",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "sette e mezza",
"Type": "time",
"Value": {
"Timex": "T07:30",
"FutureResolution": {
"time": "07:30:00"
},
"PastResolution": {
"time": "07:30:00"
}
},
"Start": 8,
"Length": 13
}
]
},
{
"Input": "Sono le sette e mezza di pomeriggio",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "sette e mezza di pomeriggio",
"Type": "time",
"Value": {
"Timex": "T19:30",
"FutureResolution": {
"time": "19:30:00"
},
"PastResolution": {
"time": "19:30:00"
}
},
"Start": 8,
"Length": 27
}
]
},
{
"Input": "Sono le sette e mezza del mattino",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "sette e mezza del mattino",
"Type": "time",
"Value": {
"Timex": "T07:30",
"FutureResolution": {
"time": "07:30:00"
},
"PastResolution": {
"time": "07:30:00"
}
},
"Start": 8,
"Length": 25
}
]
},
{
"Input": "Sono le 8 meno un quarto del mattino",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "8 meno un quarto del mattino",
"Type": "time",
"Value": {
"Timex": "T07:45",
"FutureResolution": {
"time": "07:45:00"
},
"PastResolution": {
"time": "07:45:00"
}
},
"Start": 8,
"Length": 28
}
]
},
{
"Input": "Sono le otto e 20 min di sera",
"NotSupportedByDesign": "javascript",
"Results": [
{
"Text": "otto e 20 min di sera",
"Type": "time",
"Value": {
"Timex": "T20:20",
"FutureResolution": {
"time": "20:20:00"
},
"PastResolution": {
"time": "20:20:00"
}
},
"Start": 8,
"Length": 21
}
]
},

DateTimeModel.json

Recognizers-Text/Specs/DateTime/Italian/DateTimeModel.json

Lines 1470 to 1521 in b80b58c

"Input": "Sono le sette e mezza",
"Context": {
"ReferenceDateTime": "2016-11-07T00:00:00"
},
"NotSupportedByDesign": "javascript,java",
"Results": [
{
"Text": "sette e mezza",
"TypeName": "datetimeV2.time",
"Resolution": {
"values": [
{
"timex": "T07:30",
"type": "time",
"value": "07:30:00"
},
{
"timex": "T19:30",
"type": "time",
"value": "19:30:00"
}
]
},
"Start": 8,
"End": 20
}
]
},
{
"Input": "Sone le otto e 20 di sera",
"Context": {
"ReferenceDateTime": "2016-11-07T00:00:00"
},
"NotSupportedByDesign": "javascript,java",
"Results": [
{
"Text": "otto e 20 di sera",
"TypeName": "datetimeV2.time",
"Resolution": {
"values": [
{
"timex": "T20:20",
"type": "time",
"value": "20:20:00"
}
]
},
"Start": 8,
"End": 24
}
]
},

Anyway, I have added a few more examples to DateTimeModel.json. I would appreciate it if you could take a look.

@tellarin tellarin merged commit ced7af4 into microsoft:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellarin tellarin tellarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@andrew-gradinari @tellarin @colm-dillon @samhickey25 @aitelint @shana @kevinwalshgen @rbrennangen @Conor-Keaney