[KO Number] Fixed incorrect extraction of number from datetime mention (#2863) #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellarin
approved these changes
Mar 11, 2022
Conor-Keaney
pushed a commit
to purecloudlabs/Recognizers-Text
that referenced
this pull request
Mar 25, 2022
microsoft#2863) (microsoft#2892) Co-authored-by: aitelint <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #2863.
Test case added to NumberModel.
The problem is '일' is ambiguous and is used in many expressions where it does not represent a number.
We had already encountered the issue in the past and tried to address it by adding some conditions to the regexes, but it is likely that there are still patterns where it is wrongly extracted.