Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Enabling SpanishMexican culture in Number/Unit/DateTimveV2 #2878

Merged

Conversation

colm-dillon
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Mar 2, 2022

CLA assistant check
All CLA requirements met.

@tellarin tellarin changed the title [Python] SpanishMexican support [Python] Enabling SpanishMexican culture in Number/Unit/DateTimveV2 Mar 3, 2022
Copy link
Collaborator

@tellarin tellarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking review as ongoing. Left a small comment so far.

@@ -1,7 +1,7 @@
[
{
"Input": "Tiquetes de avión baratos Madrid - Cozumel desde $ 1,234 (1234.00)",
"NotSupported": "java, javascript, python",
"NotSupported": "java, javascript",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same cases should be enabled in Spanish NumberModel too if disabled there.

@tellarin tellarin merged commit a18002e into microsoft:master Mar 3, 2022
Conor-Keaney pushed a commit to purecloudlabs/Recognizers-Text that referenced this pull request Mar 25, 2022
…icrosoft#2878)

* Enabling SpanishMexican culture in Number/Unit/DateTimveV2

* Update Spanish number specs according to review

Co-authored-by: Colm Dillon <[email protected]>
@colm-dillon colm-dillon deleted the python-spanish-mexican-support branch January 30, 2024 10:24
@Qqqq0qw Qqqq0qw mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants