-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submission schema so that hardcoded list of classes can be removed from nmdc-server
#186
Comments
@pkalita-lbl what is the submission-schema action? Do we need to add aliases? Or is this really a serve action? "Update server ingest code to leverage NMDC submission schema. |
The bullet points represent things that should be done in the submission schema (update
I don't think so.
Once this work is complete in the submission schema there is code that can be removed and/or simplified in |
I have some wishes but probably wont have a good solution for #213 in the next 24 hours. @pkalita-lbl and I have discussed some of this and agree on the underlying principles as far as a I can tell
|
I have prototyped a MIxS Environments/NMDC DH Interfaces TSV mapping file here, in response to this request That mapping also includes columns for the MIxS environmental triad slots. They aren't relevant to this issue. |
Currently
nmdc-server
maintains a hardcoded list of classes along with meta-information like display names and display statuses: https://github.com/microbiomedata/nmdc-server/blob/ccd899bf07baae6abac7049a20202d6908c72c60/web/src/views/SubmissionPortal/harmonizerApi.ts#L60 There isn't any reason why this information couldn't be derived from the schema directly with some updates. In particular:displayName
should be able to be derived from a class'stitle
. Review the existing titles, see if they align, and update if needed.schemaClass
andsampleDataSlot
could be derived from looking at the slots of theSampleData
class and the ranges of those slots. Double-check that, but there may not be any schema changes needed here.status
could be placed in a customannotation
on the classes. LinkML has astatus
metaslot https://linkml.io/linkml-model/1.7.x/docs/status/ but I'm not sure that's what we want to use here. In fact it may be worth coming up with a new name for theannotation
to avoid confusion.description
s to the interface classes (see: https://github.com/microbiomedata/submission-schema/blob/fff9173fc4aa42a609fcb7e86b3f71c0a10d5128/src/nmdc_submission_schema/schema/nmdc_submission_schema.yaml#L18911)The text was updated successfully, but these errors were encountered: