Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submission schema so that hardcoded list of classes can be removed from nmdc-server #186

Open
pkalita-lbl opened this issue Mar 4, 2024 · 5 comments
Assignees

Comments

@pkalita-lbl
Copy link
Collaborator

Currently nmdc-server maintains a hardcoded list of classes along with meta-information like display names and display statuses: https://github.com/microbiomedata/nmdc-server/blob/ccd899bf07baae6abac7049a20202d6908c72c60/web/src/views/SubmissionPortal/harmonizerApi.ts#L60 There isn't any reason why this information couldn't be derived from the schema directly with some updates. In particular:

@mslarae13
Copy link
Contributor

@pkalita-lbl what is the submission-schema action? Do we need to add aliases? Or is this really a serve action? "Update server ingest code to leverage NMDC submission schema.

@pkalita-lbl
Copy link
Collaborator Author

what is the submission-schema action?

The bullet points represent things that should be done in the submission schema (update title and descriptions, add annotations).

Do we need to add aliases?

I don't think so.

Or is this really a serve action?

Once this work is complete in the submission schema there is code that can be removed and/or simplified in nmdc-server, but that's a separate step.

@turbomam
Copy link
Member

turbomam commented Jul 22, 2024

I have some wishes but probably wont have a good solution for #213 in the next 24 hours. @pkalita-lbl and I have discussed some of this and agree on the underlying principles as far as a I can tell

  • agreed: these mappings would ideally not live as a typescript file or in the nmdc-server codebase
  • if any new mappings are required, they should be as similar to the actual MIxS Extension class names as possible. We shouldn't be coming up with still more lexical forms of these names (in MIxS, submission-schema, nmdc-server, something new...)
  • the mapping resource (or native LinkML representation) would acknowledge all of the MIxS Extensions. Currently there are some that aren't accounted for in the "published" and "disabled" status subsets. So I would propose another status like "hidden"
  • ideally the technical solution wouldn't require LinkML annotations. Maybe structured_aliases?
    • may not be readily amenable to a schemasheets implementation

@turbomam
Copy link
Member

turbomam commented Jul 23, 2024

I have prototyped a MIxS Environments/NMDC DH Interfaces TSV mapping file here, in response to this request

That mapping also includes columns for the MIxS environmental triad slots. They aren't relevant to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants