Derive Excel worksheet names from schema annotations #1311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microbiomedata/submission-schema#213
Details
Previously we used the "display name" for each template as the worksheet name when importing from/exporting to Excel files. The problem is that some of those names are > 31 characters, making them illegal values for worksheet names.
In microbiomedata/submission-schema#215 I added annotations to the relevant classes in the submission schema to indicate what the corresponding Excel worksheet name should be. Having this in the schema instead of in the
nmdc-server
code is part of a broader effort to have the schema be the single source of truth (see also microbiomedata/submission-schema#186)In these changes I am:
Testing