Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

265 inplement cromwell runner #271

Merged

Conversation

mbthornton-lbl
Copy link
Contributor

@mbthornton-lbl mbthornton-lbl commented Oct 10, 2024

This PR provides an implementation of a Cromwell Job Runner class in the workflow automation framework:

  • implement a CromwellRunner class with a submit_job method
  • implement helper method generate_submission_files and its helpers
  • update unit tests and fixtures

This PR also includes a re-organization of fixture files under sub-directories

@aclum
Copy link
Contributor

aclum commented Oct 10, 2024

looks good so far, lmk when this is out of draft.

@aclum aclum requested review from shreddd and scanon October 10, 2024 22:24
@mbthornton-lbl mbthornton-lbl requested a review from aclum October 14, 2024 20:02
@mbthornton-lbl mbthornton-lbl marked this pull request as ready for review October 14, 2024 20:06
@mbthornton-lbl mbthornton-lbl merged commit 74a6c92 into 252-workflow-automation-berkley-rc1 Oct 14, 2024
1 check passed
@mbthornton-lbl mbthornton-lbl deleted the 265-inplement-cromwell-runner branch October 14, 2024 21:34
@mbthornton-lbl mbthornton-lbl linked an issue Oct 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inplement CromwellRunner
2 participants