Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update process for using display hints directly from the schema #750

Closed
Tracked by #587
jeffbaumes opened this issue Jul 14, 2022 · 13 comments
Closed
Tracked by #587

Update process for using display hints directly from the schema #750

jeffbaumes opened this issue Jul 14, 2022 · 13 comments

Comments

@jeffbaumes
Copy link
Collaborator

Look into a process and verification that display hints from the schema are being utilized properly by the web UI. Specifically, we could look into doing this for the study metadata in the submission portal and ensure we are directly using display hints like the following in the UI:

image

@turbomam @cmungall FYI.

@aclum
Copy link
Contributor

aclum commented Apr 22, 2024

@turbomam @naglepuff @marySalvi @jeffbaumes This has come up in some of the data portal user research. What is the best practice for which schema slot should be used for a tool tip display in nmdc UIs like the data portal? The screen shot above indicates it should be slot_usage.$SLOT.annotations.display_hit.value. Is that still correct?

@aclum
Copy link
Contributor

aclum commented May 9, 2024

Default to description and have a way of overwriting it. @turbomam will do this for env context terms using annotations (ie brief_description)

@turbomam
Copy link
Member

@turbomam
Copy link
Member

@dwinston
Copy link

[not directly addressing this issue, but noting here as related]

There may be an opportunity to spin out a separate “governance tier” for slot definitions for informal annotations, represented more dynamically e.g. as a database (“slotbase”?) rather than as a set of yaml files in a git repo.

prior art / reference: https://metadata.raid.org/en/latest/#core-extended-and-local-metadata-schema-components

@turbomam
Copy link
Member

turbomam commented May 16, 2024

  • Do we want to have multiple kinds of annotations? What would their names be?
  • How would Kitware/nmdc-server access the values? Easy with Python SchemaView()
  • Who is going to populate the values?

@turbomam
Copy link
Member

turbomam commented May 16, 2024

Use alt_descriptions instead?

microbiomedata/berkeley-schema-fy24#167

@turbomam
Copy link
Member

actually alt_descriptions isn't the best choice. we do have display_hint annotations already. but I propose switching them all to tool_tip annotations.

@aclum
Copy link
Contributor

aclum commented May 31, 2024

So slot_usage.$SLOT.annotations.tool_tip.value?

@aclum
Copy link
Contributor

aclum commented Jul 12, 2024

@turbomam I don't see any examples in berkeley-schema-fy24 or nmdc-schema which illustrate your most recent suggestion.

@aclum
Copy link
Contributor

aclum commented Jul 12, 2024

Using microbiomedata/nmdc-schema#2120 as an example for how this should be formatted.

@aclum
Copy link
Contributor

aclum commented Jul 16, 2024

Example of preferred way to model this:

    annotations:
      tooltip:
        tag: tooltip
        value: GOLD Ecosystem Classification paths describe the surroundings from which an environmental sample or an organism is collected.
        annotations:
          source: https://gold.jgi.doe.gov/ecosystem_classification

@aclum aclum closed this as completed Jul 16, 2024
@turbomam
Copy link
Member

turbomam commented Jul 16, 2024

Actually, I don't recommend that format (in which the annotation's key is repeated in the tag position) unless you need to make additional annotations on the tooltip annotation.

Otherwise, this compact form is preferable (in my opionion)

    annotations:
      tooltip: GOLD Ecosystem Classification paths describe the surroundings from which an environmental sample or an organism is collected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants