-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltip annotation for gold_path_field #2120
Add tooltip annotation for gold_path_field #2120
Conversation
|
@aclum can you say where you got that definition? You wanted me to do something similar for the MIxS environmental triad as a group, right? |
@turbomam that description came from https://gold.jgi.doe.gov/ecosystem_classification, should i add that as comment? |
Added linkml comments and made tool tip a single line.
@turbomam okay to merge this in? This was tentatively approved by the refactor folks yesterday. |
I was hoping we could put the comment on the annotation itself. But that would require the use of a wordier collection form annotations:
tool_tip:
tag: tool_tip
value: GOLD Ecosystem Classification paths describe the surroundings from which an environmental sample or an organism is collected.
annotations:
source: https://gold.jgi.doe.gov/ecosystem_classification I will approve now. We can use either what I suggested above or what you already have. |
I don't have a preference, I just didn't have an example to work off of. I'll update to this format now. |
@turbomam updated the modeling to your preferred syntax. |
@@ -2968,6 +2968,12 @@ slots: | |||
abstract: true | |||
description: >- | |||
This is a grouping for any of the gold path fields | |||
annotations: | |||
tool_tip: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I've come across this spelling of "tooltip" before. I don't meant to say it's incorrect, just that I think I've only ever seen it spelled as a single word.
This PR adds a tool tip for slot gold_path_field. Description change only, no changes to example data. No migration needed.