Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what "sample" means across pages #1220

Closed
ljohnson09 opened this issue Apr 22, 2024 · 8 comments · Fixed by #1270
Closed

Clarify what "sample" means across pages #1220

ljohnson09 opened this issue Apr 22, 2024 · 8 comments · Fixed by #1270
Assignees
Labels
data portal user_research Request comes from user research activites

Comments

@ljohnson09
Copy link

Sample numbers are not consistent across pages, users were confused by what a "sample" is.

Example: GROW page - Study landing page shows 430 samples for sample count under NMDC Study Details section, but this does not align w/ the omics sample type counts underneath the title

NOTE: Alicia - Tooltip that pulls from schema

@naglepuff
Copy link
Collaborator

Image

I believe this screenshot highlights the issue being described. I can see how it could be confusing to users for the counts in the omics chips to not line up with the stated sample count. This is due to there being more than one analysis per sample. Perhaps we could update the labels in the chips or add tooltips to clarify what all of the number means (maybe we could use schema definitions here - I would need to be pointed in their direction). Any thoughts @aclum?

@aclum
Copy link
Contributor

aclum commented May 3, 2024

This primarily pertains to the main search page. The 'results in the faceted search returns number of biosamples but it is not labeled. Things get confusing if the number of samples doesn't match the number of omics records. For example with the neon soil study there are approximately 3 samples per 1 metagenome omics record.

Image

I will check with Mark on what schema slots should be used to populate tools tips.

@ssarrafan
Copy link

I'll move this to the new sprint based on the recent comment from @aclum. Can this be assigned to one person once you get clarification from Mark?

@aclum
Copy link
Contributor

aclum commented May 6, 2024

see #750, i linked this issue in slack to get clarification on what slot we should populate to be able to provide a tool tip.

@aclum
Copy link
Contributor

aclum commented May 13, 2024

My suggestion here is that for the image posted on last week we update 'Found 4475 results' to 'Found 4475 samples' where hovering over the word samples pops up a tool tip populated with the description for Class Biosample.
Assigning to just @marySalvi since we have a path forward.

@naglepuff
Copy link
Collaborator

Here's an example of us pulling descriptions out of the schema (could be a helpful reference when making the change to pull out annotations for classes):

const description = computed(() => {
const fieldSchemaName = getField(props.field, props.table);
const { schemaName } = types[props.table];
if (schemaName !== undefined) {
// @ts-ignore
const schema = NmdcSchema.$defs[schemaName];
// @ts-ignore
return schema.properties?.[fieldSchemaName.schemaName || props.field]?.description || '';
}
return '';
});

@ssarrafan
Copy link

Looks like the linked PR still needs to be reviewed so I’ll move to the next sprint.

@aclum
Copy link
Contributor

aclum commented Jun 10, 2024

Looks good on dev.

@aclum aclum moved this from External links to Done in Data Portal Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data portal user_research Request comes from user research activites
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants