Changes for AppData, LinkedAppData, and DataSection DAS indexing and updates to related js tests
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danenbm
changed the title
danenbm
changed the title
AppData, LinkedAppData, and DataSection DAS indexing and updates to related js tests
danenbm
force-pushed
the
danenbm/das-app-data
branch
from
80ecbe6 to
d3d17cb
Compare
Also add MsgPack to LinkedAppData tests
danenbm
force-pushed
the
danenbm/das-app-data
branch
from
d3d17cb to
31ca65d
Compare
blockiosaurus
approved these changes
Jul 26, 2024
danenbm
added a commit
that referenced
this pull request
Aug 6, 2024
* Adding support for additional delegates in Update Delegate plugin. * add more tests, migtrate to sdk usage * more collection tests * Updating to fit new requirements. * add test * Addressing feedback. * Adding two tests to check for root authority permissions. * Resetting index. * Addressing feedback and regenerating. * Fixing Rust tests. * Rename to App Data * Renaming Asset Linked to just Linked. * Addressing feedback. * Fixing based on feedback and fixing a loophole that allowed data sections to be added on create. * New lockfile. * New lockfile. * Fixing lockfile. * Fixing lock files. * Add `updateV2` which allows adding/removing an asset from collection (#142) * Add ability to add/remove an asset from a collection * Regenerate clients * Add back check for V1 removing from collection * Validate permission to add to new collection * Update comments * Simplify condition * Kinobi default for updateV2 and initial tests * Add test changing collection using delegate * Add wrong collection tests and collection size checks * Additional change collection tests * More checks * Update JS SDK V1 to use updateV2 * Update updateV2 test to use SDK * Use SDK test helpers * Only increment num_minted on create * Add negative test cases * Reorder tests * Add more update delegate tests, rename tests, add asserts * Separate increment into two methods * chore: Release mpl-core version 0.8.0-alpha.1 * Deploy JS client v1.1.0-alpha.0 * filter out collection fields not applicable on asset on derivation (#149) * Deploy JS client v1.1.0-alpha.1 * Adding helpers to fetch external plugins. (#154) * Adding helpers to fetch external plugins. * Convert to helper and remove extra deserialize --------- Co-authored-by: Michael Danenberg <[email protected]> * Rust client improvements (#155) * Add anchor trait implementations for BaseAssetV1 and BaseCollectionV1 * Box Asset deserialization and use helper * Box Collection deserialization, use helper, add ext plugins * Add code and test for fetching external plugin adapter data * Do not run pre-commit during merge * Add external plugin data to Asset and Collection in Rust client * Add method that only returns data offset and len, remove data_string from Asset and Collection * Update comment * Remove fetch_external_plugin_adapter_data_as_string and test wrapped * chore: Release mpl-core version 0.8.0-alpha.2 * Adding tests to msgpack since apparantly it's not disabled. * Fix updating external plugin adapters on collection (#161) * Add tests for updating AppData on asset and collection * Fix function pointers for updating collection external plugin adapters * Add more tests to create collections with external plugins * Add todo functions and rename test * Add collection update tests * Add tests for removing external plugin adapters from collection * Changes for `AppData`, `LinkedAppData`, and `DataSection` DAS indexing and updates to related js tests (#174) * Serialize external JSON data as JSON object rather than String * Do not convert MsgPack encoded data to String in tests Also add MsgPack to LinkedAppData tests * Fix test for MsgPack case * chore: Release mpl-core version 0.8.0-beta.1 * Add missing external plugin adapters to validation * Add missing parameter * Remove feature gate * Allow update delegate to validate create * Fixing incorrect test name * Allow for all plugin `Authority` types to approve lifecycle events, remove unused functions (#177) * Allow for other update_delegate authority types and remove unused functions * Make other plugin validations consistent * Add some burnDelegate tests * Switch test order * Add some freezeDelegate tests * Adding another transfer delegate test * Add more update delegate tests * Minor rename test * Adding automatic msgpack decoding. * Add AppData auth tests (#180) * Add AppData auth tests * Update js to convert schema of 0 to 0 instead of null * Use nullish coalescing operator on schema * Block adding certain external plugin adapters, add more tests * Update data section test result * Fix updating for linked lifecycle hook and app data --------- Co-authored-by: Blockiosaurus <[email protected]> Co-authored-by: Nhan Phan <[email protected]> Co-authored-by: Nhan Phan <[email protected]> Co-authored-by: blockiosaurus <[email protected]> Co-authored-by: danenbm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
String.MsgPackencoded data toStringin tests.MsgPacktoLinkedAppDatatests.AppDataexternal plugin digital-asset-rpc-infrastructure#202