Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jun 2024 feature staging to main #157

Merged
merged 64 commits into from
Aug 6, 2024
Merged

Jun 2024 feature staging to main #157

merged 64 commits into from
Aug 6, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Jul 1, 2024

Notes

  • Changes reviewed from previous PRs and audited (incremental completed 8/6/2024).
  • jun-2024-feature-staging already contains all commits from main, so after it is merged, the two branches will 100% match.

blockiosaurus and others added 30 commits May 21, 2024 22:40
* main:
  chore: Release mpl-core version 0.7.0
  Process internal and external plugins together in indexable asset (#136)
  Nhan/revert burn rent (#134)
  Improve DAS indexing for unknown lifecycle checks (#133)
  Add external plugins handling to `IndexableAsset` (#128)
  add lint precommit hook (#127)
  use solana 1.18 to deploy (#129)
  Third party plugins staging to main (#107)
…te-delegates

Adding support for additional delegates in Update Delegate plugin.
…142)

* Add ability to add/remove an asset from a collection

* Regenerate clients

* Add back check for V1 removing from collection

* Validate permission to add to new collection

* Update comments

* Simplify condition

* Kinobi default for updateV2 and initial tests

* Add test changing collection using delegate

* Add wrong collection tests and collection size checks

* Additional change collection tests

* More checks

* Update JS SDK V1 to use updateV2

* Update updateV2 test to use SDK

* Use SDK test helpers

* Only increment num_minted on create

* Add negative test cases

* Reorder tests

* Add more update delegate tests, rename tests, add asserts

* Separate increment into two methods
…g and updates to related js tests (#174)

* Serialize external JSON data as JSON object rather than String

* Do not convert MsgPack encoded data to String in tests

Also add MsgPack to LinkedAppData tests

* Fix test for MsgPack case
…emove unused functions (#177)

* Allow for other update_delegate authority types and remove unused functions

* Make other plugin validations consistent

* Add some burnDelegate tests

* Switch test order

* Add some freezeDelegate tests

* Adding another transfer delegate test

* Add more update delegate tests

* Minor rename test
* Add AppData auth tests

* Update js to convert schema of 0 to 0 instead of null

* Use nullish coalescing operator on schema

* Block adding certain external plugin adapters, add more tests

* Update data section test result

* Fix updating for linked lifecycle hook and app data
@danenbm danenbm marked this pull request as ready for review August 6, 2024 18:07
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, lots of changes but everything looks good for the final merge!

@danenbm danenbm merged commit 8a53809 into main Aug 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants