generated from metaplex-foundation/solana-project-template
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jun 2024 feature staging to main #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: chore: Release mpl-core version 0.7.0 Process internal and external plugins together in indexable asset (#136) Nhan/revert burn rent (#134) Improve DAS indexing for unknown lifecycle checks (#133) Add external plugins handling to `IndexableAsset` (#128) add lint precommit hook (#127) use solana 1.18 to deploy (#129) Third party plugins staging to main (#107)
…ions to be added on create.
…te-delegates Adding support for additional delegates in Update Delegate plugin.
Adding in Data sections and parent plugins
…142) * Add ability to add/remove an asset from a collection * Regenerate clients * Add back check for V1 removing from collection * Validate permission to add to new collection * Update comments * Simplify condition * Kinobi default for updateV2 and initial tests * Add test changing collection using delegate * Add wrong collection tests and collection size checks * Additional change collection tests * More checks * Update JS SDK V1 to use updateV2 * Update updateV2 test to use SDK * Use SDK test helpers * Only increment num_minted on create * Add negative test cases * Reorder tests * Add more update delegate tests, rename tests, add asserts * Separate increment into two methods
…g and updates to related js tests (#174) * Serialize external JSON data as JSON object rather than String * Do not convert MsgPack encoded data to String in tests Also add MsgPack to LinkedAppData tests * Fix test for MsgPack case
Fixing incorrect test name
…emove unused functions (#177) * Allow for other update_delegate authority types and remove unused functions * Make other plugin validations consistent * Add some burnDelegate tests * Switch test order * Add some freezeDelegate tests * Adding another transfer delegate test * Add more update delegate tests * Minor rename test
Automatic msgpack decoding in SDK
* Add AppData auth tests * Update js to convert schema of 0 to 0 instead of null * Use nullish coalescing operator on schema * Block adding certain external plugin adapters, add more tests * Update data section test result * Fix updating for linked lifecycle hook and app data
blockiosaurus
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, lots of changes but everything looks good for the final merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
jun-2024-feature-staging
already contains all commits frommain
, so after it is merged, the two branches will 100% match.